Re: [PATCH] KVM: arm64: selftests: Check ID regs are immutable after a failed run

Mark Brown <[email protected]> Tue, 4 Aug 2026 19:36:24 +0100

Newsgroups	org.infradead.lists.linux-arm-kernel,dev.linux.lists.kvmarm,org.kernel.vger.linux-kernel
Message-ID	<[email protected]>

On Tue, Aug 04, 2026 at 07:30:44PM +0100, Fuad Tabba wrote:
> On Tue, 4 Aug 2026 at 19:14, Mark Brown <[email protected]> wrote:

> > > +     TEST_ASSERT(r < 0 && errno == EBUSY,
> > > +                 "ID reg write after failed first run: r=%d errno=%d",
> > > +                 r, errno);
> > > +     TEST_ASSERT_EQ(vcpu_get_reg(vcpu, reg), val);

> > > +     kvm_vm_free(vm);
> > > +     ksft_test_result_pass("%s\n", __func__);

> > Mixing TEST_ASSERT() and ksft_test_result_ in the same test program also
> > interacts really poorly with automation, TEST_ASSERT() just kills the

> Agreed, but it looks file-wide rather than specific to this test, so I
> would rather leave it to your series than convert one function. Happy
> to follow once that lands.

Unfortunately at the minute it's not even consistent within the program -
the MPAM tests in there do use ksft_ based reporting, while they do so
with inconsistent strings you at least get all the results out if it's
just them that blow up.

signature.asc (application/pgp-signature, 488 B)