Re: [PATCH v9 10/13] coresight: etm4x: exclude ss_status from drvdata->config
Leo Yan <[email protected]>
| Newsgroups | org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
On Sat, Jul 25, 2026 at 12:36:42PM +0100, Yeoreum Yun wrote: > The purpose of TRCSSCSRn register is to show status of > the corresponding Single-shot Comparator Control and input supports. I vaguely remember that we discussed the issue with always clearing drvdata::ss_status in hw_enable(), which might result in single-shot does not work properly in a perf session. This issue is not introduced by this patch, and I think we agreed to address it later. Could you document it in the commit log so that we can understand and track the issue later. > That means writable field's purpose for reset or restore from idle status > not for configuration. > > Therefore, exclude ss_status from drvdata->config and move it to drvdata. > > Signed-off-by: Yeoreum Yun <[email protected]> With above amending: Reviewed-by: Leo Yan <[email protected]>