Re: [PATCH] mailbox: cix: validate channel parameters early and convert to dev_err_probe

Jassi Brar <[email protected]>
Newsgroups org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-kernel
Message-ID <CABb+yY0CGK82b=rjwkhuc9doBaLrMcw__ru8yX2cmL+3yyBYZg@mail.gmail.com>
On Fri, Jul 24, 2026 at 1:42 AM <[email protected]> wrote:
>
> From: Surendra Singh Chouhan <[email protected]>
>
> cix_mbox_startup() checked fast channel index constraints (index < 0 ||
> index > CIX_MBOX_FAST_IDX) inside the channel switch block after
> calling request_irq(). If validation failed, it triggered a free_irq()
> cleanup path. Validating channel parameters prior to request_irq()
> avoids unnecessary IRQ registration/teardown churn.
>
> In addition, cix_mbox_probe() logged property errors referencing
> "cix,mbox_dir" (with an underscore) instead of the actual DT property
> name "cix,mbox-dir". Convert cix_mbox_probe() error paths to use
> dev_err_probe() and fix the DT property string spelling.
>
These should be two patches.

Thanks
Jassi
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.