Re: [PATCH] net: xilinx: axienet: Propagate errors from optional IRQ lookup
Bui Duc Phuc <[email protected]>
| Newsgroups | org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-arm-msm,org.kernel.vger.linux-kernel,org.kernel.vger.netdev |
|---|---|
| Message-ID | <CAABR9nHApFe45RCcXoHDiNh6yqnyVLxgD=oFmpYohQ=QT9=wfA@mail.gmail.com> |
Hi Andrew, Thanks for the feedback. > > lp->eth_irq is assigned from platform_get_irq_optional(), which returns a > > positive IRQ number on success or a negative error code on failure. > > Therefore, a value of 0 is not possible here, so changing <= 0 to < 0 > > is directly related to the error handling described in the commit message. > > I think this is a separate change. You can then reference the > documentation, and its example: > > https://elixir.bootlin.com/linux/v7.1.8/source/drivers/base/platform.c#L270 > I’ll split this change into a separate commit. Best regards, Phuc