Re: [PATCH] arm64/kernel: Expose the running CPU of a native task in TPIDRRO_EL0
"Guilherme G. Piccoli" <[email protected]>
| Newsgroups | org.infradead.lists.linux-arm-kernel |
|---|---|
| Message-ID | <[email protected]> |
On 15/08/2026 13:52, Bradley Morgan wrote: > Hi, we meet again, :) > > Well, I looked at this assembly code until I was blind,heh, and I > couldnt particularly find anything bad about it, well, I know I'll > probably get these arm pros saying I'm dumb or something for not > noticing a mistake, but I don't see any mistakes asm side. > > > For process.c, I really really like your comment, it's, straight > to the point, did your LLM write this, or did you write it? > > For your patch; > > Reviewed-by: Bradley Morgan <[email protected]> > > > Note: I hope I don't get plonked, I couldnt find anything wrong, but who knows > Thanks! Hey Bradley \o Thanks for your review. I wrote the comment myself, but LLM helped me with ping-pong reviews, for example, checking corner cases, commenting on potential ideas. For example, in a first version I just updated this write_sysreg() to the CPU id, but then started to think "why am I doing this if the register is updated at every exit?". "Talking" with the LLM gave me confidence to suppress this write, due to the reason well explained in the comment heh Cheers!