Re: [PATCH] arm64: dts: ti: k3-am625-beagleplay: Add boot phase tags for pmic
Anshul Dalal <[email protected]>
| Newsgroups | org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
On Thu Aug 13, 2026 at 11:14 PM IST, Hari Prasath G E wrote: > Hello Anshul, > > On 8/13/2026 1:58 PM, Anshul Dalal wrote: >> The PMIC regulators for beagleplay are required for booting, therefore >> this patch moves the corresponding 'bootph-all' tag from the parent >> tps65219 node to all the regulator sub-nodes. >> > > Was there any issue with this platform that is triggering this change > now ? I think we need a fixes tag here below. The bootph tags were missing from the start. If a fixes tag is warranted here, should it point to the initial patch adding the dts? > >> Signed-off-by: Anshul Dalal <[email protected]> >> --- >> arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts | 8 +++++++- >> 1 file changed, 7 insertions(+), 1 deletion(-) >> >> diff --git a/arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts b/arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts >> index c468b9c5fc09a..5f7265c426bbe 100644 >> --- a/arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts >> +++ b/arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts >> @@ -681,7 +681,6 @@ rtc: rtc@68 { >> }; >> >> tps65219: pmic@30 { >> - bootph-all; > > Wouldn't removing this from here prevent the driver from binding at all > in that phase ? I am not sure if the child tag below would also imply to > the parent node here, pls check once. U-Boot's binman tool propagates the bootph-all nodes to all the parents and thus the bootph-all for pmic node is redundant. > > https://github.com/devicetree-org/dt-schema/blob/main/dtschema/schemas/bootph.yaml > > Moreover, k3-am62-pocketbeagle2.dts seems to use the same PMIC. Isn't > the same change required for this platform ? > I will give it a try but pocketbeagle2 likely requires a similar fix. > Regards, > Hari > >> compatible = "ti,tps65219"; >> reg = <0x30>; >> buck1-supply = <&vsys_5v0>; >> @@ -709,6 +708,7 @@ buck1_reg: buck1 { >> regulator-max-microvolt = <850000>; >> regulator-boot-on; >> regulator-always-on; >> + bootph-all; >> }; >> >> buck2_reg: buck2 { >> @@ -717,6 +717,7 @@ buck2_reg: buck2 { >> regulator-max-microvolt = <1800000>; >> regulator-boot-on; >> regulator-always-on; >> + bootph-all; >> }; >> >> buck3_reg: buck3 { >> @@ -725,6 +726,7 @@ buck3_reg: buck3 { >> regulator-max-microvolt = <1200000>; >> regulator-boot-on; >> regulator-always-on; >> + bootph-all; >> }; >> >> ldo1_reg: ldo1 { >> @@ -739,6 +741,7 @@ ldo1_reg: ldo1 { >> regulator-allow-bypass; >> regulator-boot-on; >> regulator-always-on; >> + bootph-all; >> }; >> >> ldo2_reg: ldo2 { >> @@ -747,6 +750,7 @@ ldo2_reg: ldo2 { >> regulator-max-microvolt = <850000>; >> regulator-boot-on; >> regulator-always-on; >> + bootph-all; >> }; >> >> ldo3_reg: ldo3 { >> @@ -755,6 +759,7 @@ ldo3_reg: ldo3 { >> regulator-max-microvolt = <1800000>; >> regulator-boot-on; >> regulator-always-on; >> + bootph-all; >> }; >> >> ldo4_reg: ldo4 { >> @@ -763,6 +768,7 @@ ldo4_reg: ldo4 { >> regulator-max-microvolt = <2500000>; >> regulator-boot-on; >> regulator-always-on; >> + bootph-all; >> }; >> }; >> }; >> >> --- >> base-commit: 848acc8ffe1b7cd5f1bf427b93069becfebc2c9d >> change-id: 20260813-beagleplay_pmic_boot_phase_fix-c04b7f55de63 >> >> Best regards, >> -- >> Anshul Dalal <[email protected]> >> >>