Re: [PATCH v5 3/9] irqchip/imx-irqsteer: Validate IRQ count before creating domain
Fabio Estevam <[email protected]>
| Newsgroups | org.infradead.lists.linux-arm-kernel,dev.linux.lists.imx,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <CAOMZO5CdZk3oyMpwPcTEeROBWBr70r9J7Vt-MiEA4+Y7abE5Sw@mail.gmail.com> |
Hi Zhipeng, On Mon, Aug 24, 2026 at 6:38 AM Zhipeng Wang (OSS) <[email protected]> wrote: > Hi Frank, > > Makes sense, I'll restructure it that way for the next version: > > - Move Fabio's IRQ-count validation up so the count is validated before > the domain is created, and add proper error handling there. > - Since the invalid count is then rejected before the domain exists, > the domain leak can no longer happen, so managing the domain with > devm is no longer a fix. I'll drop its Fixes tag and reframe it as an > improvement. > - Move that devm conversion after the new devm_irq_domain_create_linear() > helper, together with the other cleanup. My motivation for sending [PATCH v4 1/2] irqchip/imx-irqsteer: Convert to devm_pm_runtime_enable() https://lore.kernel.org/lkml/aoXZf2z-50H8rimI@lizhi-Precision-Tower-5810/ was the "Unbalanced pm_runtime_enable!" error during driver unbinding. This was seen on kernel 6.18, so I would like this error fixed in your series with a Fixes tag, so stable kernels like 6.18 can be fixed. Thanks