Re: [PATCH net v2 6/6] selftests: drv-net: Add VLAN test

On Mon, 24 Aug 2026 11:50:12 +0000 Ovidiu Panait wrote:
> > +            no_change = False
> > +            if current[name]["fixed"]:
> > +                raise KsftXfailEx(f"Device does not support {name}")
> > 
> > I'm not too familiar with the self test framework, so i could have
> > this wrong.
> > 
> > It looks to me like you fail the text if it is fixed. But does not
> > fixed just mean the hardware does not support it? So i think it should
> > actually skip the test?
> 
> I compared the XFAIL vs SKIP usage when a certain hw feature is not
> supported and it seems that most tests use SKIP (tso.py, gro_hw.py,
> hds.py, ntuple.py, etc). I will switch to SKIP in v3, which should also
> allow for some reduction in code duplication across tests.

Please double check that the test passes on netdevsim (without NETIF)
We can't have skips in SW mode, all drivers/net tests are expected to 
run against netdevsim, really. If they don't they should live under hw/
(where the SKIP vs XFAIL distinction does not matter).

BTW there are ruff check and new pylint --disable=R warnings in the
python code, pls fix