Re: [PATCH v3 8/9] arm64: dts: st: Add USB nodes on stm32mp231
Marek Vasut <[email protected]>
| Newsgroups | org.infradead.lists.linux-arm-kernel,org.infradead.lists.linux-phy,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel,org.kernel.vger.linux-usb |
|---|---|
| Message-ID | <[email protected]> |
On 8/24/26 3:18 PM, Fabrice Gasnier wrote:
[...]
>> syscfg: syscon@44230000 {
>> - compatible = "st,stm32mp23-syscfg", "syscon";
>> + compatible = "st,stm32mp23-syscfg", "syscon", "simple-mfd";
>> reg = <0x44230000 0x10000>;
>> #clock-cells = <0>;
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>> +
>> + usb2_phy1: phy@2400 {
>> + compatible = "st,stm32mp25-usb2phy1";
>> + reg = <0x2400 0x24>;
>
> Hello Marek,
Hello Fabrice,
> The size 0x24, covers the PHY control, trimming and vbus control logic
> for PHY1 (USBH). So this allows to later extend the driver for that, right ?
Correct.
>> + #phy-cells = <0>;
>> + #clock-cells = <1>;
>> + clocks = <&rcc CK_KER_USB2PHY1>;
>> + resets = <&rcc USB2PHY1_R>;
>> + status = "disabled";
>> + };
>> +
>> + usb2_phy2: phy@2800 {
>> + compatible = "st,stm32mp25-usb2phy2";
>> + reg = <0x2800 0xc>;
>
> Then here, I guess the size should cover also trimming regs ? e.g. 0x10 ?
> reg = <0x2800 0x10>;
Uh, yes, fixed in V4, thanks !