Re: [PATCH 04/17] i3c: renesas: Follow the reset deassert order used in probe
Frank Li <[email protected]>
| Newsgroups | org.infradead.lists.linux-i3c,org.kernel.vger.linux-kernel,org.kernel.vger.linux-renesas-soc,org.kernel.vger.stable |
|---|---|
| Message-ID | <ahCqWABV7Li4ZqSq@lizhi-Precision-Tower-5810> |
On Fri, May 22, 2026 at 01:18:02PM +0300, Claudiu Beznea wrote: > From: Claudiu Beznea <[email protected]> > > Use the same reset deassert order in the resume and probe paths to avoid > potential failures due to ordering differences. > > Fixes: e7218986319b ("i3c: renesas: Add suspend/resume support") > Cc: [email protected] > Signed-off-by: Claudiu Beznea <[email protected]> > --- Reviewed-by: Frank Li <[email protected]> > drivers/i3c/master/renesas-i3c.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/i3c/master/renesas-i3c.c b/drivers/i3c/master/renesas-i3c.c > index 6c23f956ad2a..d2f29ed0b6ed 100644 > --- a/drivers/i3c/master/renesas-i3c.c > +++ b/drivers/i3c/master/renesas-i3c.c > @@ -1434,17 +1434,17 @@ static int renesas_i3c_resume_noirq(struct device *dev) > struct renesas_i3c *i3c = dev_get_drvdata(dev); > int i, ret; > > - ret = reset_control_deassert(i3c->presetn); > + ret = reset_control_deassert(i3c->tresetn); > if (ret) > return ret; > > - ret = reset_control_deassert(i3c->tresetn); > + ret = reset_control_deassert(i3c->presetn); > if (ret) > - goto err_presetn; > + goto err_tresetn; > > ret = clk_bulk_enable(i3c->num_clks, i3c->clks); > if (ret) > - goto err_tresetn; > + goto err_presetn; > > /* Re-store I3C registers value. */ > renesas_writel(i3c->regs, STDBR, i3c->i3c_STDBR); > @@ -1465,10 +1465,10 @@ static int renesas_i3c_resume_noirq(struct device *dev) > > return 0; > > -err_tresetn: > - reset_control_assert(i3c->tresetn); > err_presetn: > reset_control_assert(i3c->presetn); > +err_tresetn: > + reset_control_assert(i3c->tresetn); > return ret; > } > > -- > 2.43.0 > -- linux-i3c mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-i3c