Re: [PATCH 17/17] i3c: renesas: Add runtime PM support
Claudiu Beznea <[email protected]>
| Newsgroups | org.infradead.lists.linux-i3c,org.kernel.vger.linux-kernel,org.kernel.vger.linux-renesas-soc |
|---|---|
| Message-ID | <[email protected]> |
On 5/23/26 13:23, Claudiu Beznea wrote: >>> + i3c->dev = &pdev->dev; >>> + pm_runtime_set_autosuspend_delay(&pdev->dev, 300); >>> + pm_runtime_use_autosuspend(&pdev->dev); >>> + ret = devm_add_action_or_reset(&pdev->dev, >>> renesas_i3c_dont_use_autosuspend, >>> + i3c->dev); >> >> do you cleanup resource in renesas_i3c_dont_use_autosuspend(), look likes >> needn't it. > > According to documentation at [1] this is necessary. > > [1] https://elixir.bootlin.com/linux/v7.1-rc4/source/Documentation/power/ > runtime_pm.rst#L616 Actually, the cleanup helper of devm_pm_runtime_enable() takes care of this, thus I'll be removing the renesas_i3c_dont_use_autosuspend(). Thank you, Claudiu -- linux-i3c mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-i3c