Re: [PATCH v10 1/9] i3c: master: rename i3c_master_reattach_i3c_dev() to *_locked

On Mon, May 25, 2026 at 12:12:01PM +0530, Lakshay Piplani wrote:
> Rename i3c_master_reattach_i3c_dev() to *_locked() to make the locking
> requirement explicit and consistent with other I3C core helpers that
> require the bus lock to be held by the caller.
>
> Signed-off-by: Lakshay Piplani <[email protected]>
>

Reviewed-by: Frank Li <[email protected]>

> ---
> Changes in v10:
>  - Rename i3c_master_reattach_i3c_dev() to *_locked to reflect required
>    bus locking
> ---
> ---
>  drivers/i3c/master.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c
> index 5cd4e5da2233..e89d73508b9a 100644
> --- a/drivers/i3c/master.c
> +++ b/drivers/i3c/master.c
> @@ -1652,8 +1652,8 @@ static int i3c_master_attach_i3c_dev(struct i3c_master_controller *master,
>  	return 0;
>  }
>
> -static int i3c_master_reattach_i3c_dev(struct i3c_dev_desc *dev,
> -				       u8 old_dyn_addr)
> +static int i3c_master_reattach_i3c_dev_locked(struct i3c_dev_desc *dev,
> +					      u8 old_dyn_addr)
>  {
>  	struct i3c_master_controller *master = i3c_dev_get_master(dev);
>  	int ret;
> @@ -1742,7 +1742,7 @@ static int i3c_master_early_i3c_dev_add(struct i3c_master_controller *master,
>  		goto err_detach_dev;
>
>  	i3cdev->info.dyn_addr = i3cdev->boardinfo->init_dyn_addr;
> -	ret = i3c_master_reattach_i3c_dev(i3cdev, 0);
> +	ret = i3c_master_reattach_i3c_dev_locked(i3cdev, 0);
>  	if (ret)
>  		goto err_rstdaa;
>
> @@ -2358,7 +2358,7 @@ int i3c_master_add_i3c_dev_locked(struct i3c_master_controller *master,
>  		if (!ret) {
>  			old_dyn_addr = newdev->info.dyn_addr;
>  			newdev->info.dyn_addr = expected_dyn_addr;
> -			i3c_master_reattach_i3c_dev(newdev, old_dyn_addr);
> +			i3c_master_reattach_i3c_dev_locked(newdev, old_dyn_addr);
>  		} else {
>  			dev_err(&master->dev,
>  				"Failed to assign reserved/old address to device %d%llx",
> --
> 2.25.1
>

-- 
linux-i3c mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-i3c