Re: [PATCH v1] i3c: mipi-i3c-hci: Use named initializers for platform_device_id's .driver_data
Adrian Hunter <[email protected]>
| Newsgroups | org.infradead.lists.linux-i3c,org.kernel.vger.linux-kernel |
|---|---|
| Organization | Intel Finland Oy, Registered Address: c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo, Business Identity Code: 0357606 - 4, Domiciled in Helsinki |
| Message-ID | <[email protected]> |
On 16/06/2026 17:34, Uwe Kleine-König (The Capable Hub) wrote: > The assignment in this driver uses a mixed way to initialize the > platform_device_id array. .name is assigned by name and .driver_data by > position. Unify that to use named assignment for both struct members. > This is needed for a planned change to struct platform_device_id > replacing .driver_data by an anonymous union. > > Signed-off-by: Uwe Kleine-König (The Capable Hub) <[email protected]> Reviewed-by: Adrian Hunter <[email protected]> > --- > drivers/i3c/master/mipi-i3c-hci/core.c | 13 ++++++++----- > 1 file changed, 8 insertions(+), 5 deletions(-) > > diff --git a/drivers/i3c/master/mipi-i3c-hci/core.c b/drivers/i3c/master/mipi-i3c-hci/core.c > index 3a3a9a3d4dec..e80aa1f5722e 100644 > --- a/drivers/i3c/master/mipi-i3c-hci/core.c > +++ b/drivers/i3c/master/mipi-i3c-hci/core.c > @@ -1189,11 +1189,14 @@ static const struct acpi_device_id i3c_hci_acpi_match[] = { > MODULE_DEVICE_TABLE(acpi, i3c_hci_acpi_match); > > static const struct platform_device_id i3c_hci_driver_ids[] = { > - { .name = "intel-lpss-i3c", HCI_QUIRK_RPM_ALLOWED | > - HCI_QUIRK_RPM_IBI_ALLOWED | > - HCI_QUIRK_RPM_PARENT_MANAGED | > - HCI_QUIRK_DMA_ABORT_REQUIRES_PIO_RESET | > - HCI_QUIRK_DMA_REQUIRES_HC_ABORT }, > + { > + .name = "intel-lpss-i3c", > + .driver_data = HCI_QUIRK_RPM_ALLOWED | > + HCI_QUIRK_RPM_IBI_ALLOWED | > + HCI_QUIRK_RPM_PARENT_MANAGED | > + HCI_QUIRK_DMA_ABORT_REQUIRES_PIO_RESET | > + HCI_QUIRK_DMA_REQUIRES_HC_ABORT, > + }, > { /* sentinel */ } > }; > MODULE_DEVICE_TABLE(platform, i3c_hci_driver_ids); > > base-commit: 8d6dbbbe3ba62de0a63e962ee004afb848c8e3ac -- linux-i3c mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-i3c