Re: [PATCH 1/3] i3c: mipi-i3c-hci: Enable IBI threshold interrupt by default in PIO mode

On Fri, Jul 10, 2026 at 02:46:00AM +0000, Frank Li wrote:
>
> On Thu, Jul 09, 2026 at 03:17:42PM +0800, Jian-Ming Liao wrote:
> > Enable the IBI threshold interrupt (STAT_IBI_STATUS_THLD) by default
> > during PIO initialization. This ensures that Hot-Join requests and
> > early IBIs from devices that have not yet formally requested routing
>
> Do you means not call i3c_device_request_ibi()?
>
> Frank

Hi Frank,

Thank you for the feedback.

To provide more context, i3c_device_request_ibi() is indeed being called.
However, according to the HCI spec, if the driver needs to receive interrupts
from the IBI, the STAT_IBI_STATUS_THLD bit in PIO_INTR_SIGNAL_ENABLE must be
set. I noticed that the current driver implementation does not handle this
flag, not even in i3c_device_request_ibi().

Would you recommend handling this in hci_pio_request_ibi() to ensure it's
only enabled when requested? Or is there a preferred way in the I3C framework
to implement this kind of configuration?

I would appreciate your guidance on the best approach to handle this
without compromising the common code path.

Best regards,
Jian-Ming Liao

> > are properly captured, improving system responsiveness and stability.

> > -     pio->enabled_irqs = STAT_ALL_ERRORS;
> > +     pio->enabled_irqs = STAT_ALL_ERRORS | STAT_IBI_STATUS_THLD;

-- 
linux-i3c mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-i3c