Re: [PATCH v3 2/8] dt-bindings: gpio: cdns: add Axiado AX3005 GPIO variant
Swark Yang <[email protected]> Fri, 17 Jul 2026 15:57:48 +0800
| Newsgroups | org.infradead.lists.linux-i3c,dev.linux.lists.sashiko-reviews,org.kernel.vger.linux-devicetree |
|---|---|
| Message-ID | <[email protected]> |
On 7/17/2026 12:00 PM, [email protected] wrote: > Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: > - [High] The schema enforces a 3-item compatible string chain that unintentionally forces AX3005 devices to inherit an AX3000-specific driver quirk, contradicting the commit message. > -- Thanks for the report. To clarify, the 3-item fallback in the code is intentional and correct. The AX3005 GPIO block is fully compatible with the AX3000 implementation and indeed requires the exact same driver quirks (such as the specific direction mode and output enable handling). The issue is just a poor description in my commit message. It should have been worded as follows: "Add binding for the Axiado AX3005 GPIO controller. The AX3005 GPIO block is fully compatible with the AX3000 implementation and requires the same driver quirks. Therefore, it is added with a fallback to the 'axiado,ax3000-gpio' compatible string, which in turn falls back to the generic 'cdns,gpio-r1p02'." I will hold off on sending a v4 just for this commit message update to avoid unnecessary noise on the list. I'll wait for further review comments on the rest of the series and will include this updated message if a v4 re-roll is needed. Best Regards, Swark -- linux-i3c mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-i3c