Re: [PATCH v2 1/2] dt-bindings: i3c: dw: Document missing optional core reset

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] The binding schema adds the `resets` property but intentionally omits `reset-names`. The driver strictly requires `reset-names = "core_rst"` to find the reset control, causing it to silently ignore the reset.
--

--- Patch [1]: [PATCH v2 1/2] dt-bindings: i3c: dw: Document missing optional core reset ---
commit 673b06088a9b59875d717db2c9afb56295ac87a9
Author: Shubham Patil <[email protected]>

dt-bindings: i3c: dw: Document missing optional core reset

This commit documents an optional core reset property for the DesignWare I3C
master IP. It adds the resets property with a maxItems of 1 to the schema
but explicitly drops the reset-name property.

> diff --git a/Documentation/devicetree/bindings/i3c/snps,dw-i3c-master.yaml b/Documentation/devicetree/bindings/i3c/snps,dw-i3c-master.yaml
> index e803457d3f554..dc7ee38001d6d 100644
> --- a/Documentation/devicetree/bindings/i3c/snps,dw-i3c-master.yaml
> +++ b/Documentation/devicetree/bindings/i3c/snps,dw-i3c-master.yaml
> @@ -38,6 +38,9 @@ properties:
>    interrupts:
>      maxItems: 1
>  
> +  resets:
> +    maxItems: 1
> +

[Severity: High]
Since this schema intentionally omits reset-names, device trees cannot
provide it without breaking schema validation.

However, doesn't the driver explicitly rely on reset-names to find this
reset control?

Looking at dw_i3c_common_probe() in drivers/i3c/master/dw-i3c-master.c:

	master->core_rst = devm_reset_control_get_optional_exclusive_deasserted(
					&pdev->dev, "core_rst");

Because this searches for the "core_rst" string in the reset-names
property, won't it fail to find the reset and silently return NULL
without the property being defined in the device tree?

This would turn all subsequent reset operations into no-ops. Should
reset-names be added back to the binding to match the driver's
expectations?

>    power-domains:
>      maxItems: 1
>

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1

-- 
linux-i3c mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-i3c