Re: [PATCH] i3c: fix potential NULL dereference in send_ccc_cmd_locked

[email protected] Tue, 28 Jul 2026 06:46:36 +0000
Newsgroups org.infradead.lists.linux-i3c
Message-ID <[email protected]>
VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg
MSBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6CgpQcmUtZXhpc3RpbmcgaXNzdWVzOgot
IFtNZWRpdW1dIFRoaXMgcHJvYmxlbSB3YXNuJ3QgaW50cm9kdWNlZCBieSB0aGlzIHBhdGNoLCBi
dXQgdGhlIHBhdGNoIHByb3ZpZGVzIGFuIGluY29tcGxldGUgZml4IGZvciBhIHRoZW9yZXRpY2Fs
IE5VTEwgcG9pbnRlciBkZXJlZmVyZW5jZSwgbGVhdmluZyBhbiBpZGVudGljYWwgZGVyZWZlcmVu
Y2UgdW5oYW5kbGVkIG9uIHRoZSBzdWNjZXNzIHBhdGguCi0tCgotLS0gUGF0Y2ggWzFdOiBbUEFU
Q0hdIGkzYzogZml4IHBvdGVudGlhbCBOVUxMIGRlcmVmZXJlbmNlIGluIHNlbmRfY2NjX2NtZF9s
b2NrZWQgLS0tCmNvbW1pdCBlMjk0NTVhNDYxNjYwOGVlNjIzZTMwMWM5NDVhMDg3YjM3MGY2OThm
CkF1dGhvcjogSG9uZ2xpbmcgWmVuZyA8emVuZ2hvbmdsaW5nQGt5bGlub3MuY24+CgppM2M6IGZp
eCBwb3RlbnRpYWwgTlVMTCBkZXJlZmVyZW5jZSBpbiBzZW5kX2NjY19jbWRfbG9ja2VkCgpUaGlz
IHBhdGNoIHJlc3RyaWN0cyByZXNldHRpbmcgdGhlIHBheWxvYWQgYWN0dWFsX2xlbiB0byBESVJF
Q1QgY29tbWFuZHMKdG8gYXZvaWQgYSBwb3RlbnRpYWwgTlVMTCBwb2ludGVyIGRlcmVmZXJlbmNl
IGZvciBicm9hZGNhc3QgY29tbWFuZHMgd2l0aApOVUxMIGRlc3RzIGFuZCBuZGVzdHMgPiAwLgoK
PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9pM2MvbWFzdGVyLmMgYi9kcml2ZXJzL2kzYy9tYXN0ZXIu
Ywo+IC0tLSBhL2RyaXZlcnMvaTNjL21hc3Rlci5jCj4gKysrIGIvZHJpdmVycy9pM2MvbWFzdGVy
LmMKClsgLi4uIF0KCj4gQEAgLTEwNTEsNyArMTA1MSw3IEBAIHN0YXRpYyBpbnQgaTNjX21hc3Rl
cl9zZW5kX2NjY19jbWRfbG9ja2VkKHN0cnVjdCBpM2NfbWFzdGVyX2NvbnRyb2xsZXIgKm1hc3Rl
ciwKPiAgCWZvciAoYXR0ZW1wdCA9IDA7IGF0dGVtcHQgPCBtYXhfYXR0ZW1wdHM7IGF0dGVtcHQr
Kykgewo+ICAJCXVuc2lnbmVkIGludCBpOwo+ICAKPiAtCQlpZiAoY21kLT5ybncpCj4gKwkJaWYg
KGNtZC0+cm53ICYmIChjbWQtPmlkICYgSTNDX0NDQ19ESVJFQ1QpKQo+ICAJCQlmb3IgKGkgPSAw
OyBpIDwgY21kLT5uZGVzdHM7IGkrKykKPiAgCQkJCWNtZC0+ZGVzdHNbaV0ucGF5bG9hZC5hY3R1
YWxfbGVuID0gMDsKPiAgCj4gIAkJY21kLT5lcnIgPSBJM0NfRVJST1JfVU5LTk9XTjsKPiAgCQly
ZXQgPSBtYXN0ZXItPm9wcy0+c2VuZF9jY2NfY21kKG1hc3RlciwgY21kKTsKPiAgCQlpZiAoIXJl
dCAmJiBjbWQtPmVyciA9PSBJM0NfRVJST1JfVU5LTk9XTikKPiAgCQkJYnJlYWs7Cj4gIAl9Cj4g
IAo+ICAJaWYgKCFyZXQpCj4gIAkJcmV0ID0gaTNjX2NjY192YWxpZGF0ZV9wYXlsb2FkX2xlbihj
bWQpOwoKW1NldmVyaXR5OiBNZWRpdW1dClRoaXMgaXMgYSBwcmUtZXhpc3RpbmcgaXNzdWUsIGJ1
dCBkb2VzIHRoaXMgcGF0Y2ggbGVhdmUgYW4gaWRlbnRpY2FsIE5VTEwKcG9pbnRlciBkZXJlZmVy
ZW5jZSB1bmhhbmRsZWQgb24gdGhlIHN1Y2Nlc3MgcGF0aD8KCklmIGEgYnJvYWRjYXN0IGNvbW1h
bmQgKHdoZXJlIEkzQ19DQ0NfRElSRUNUIGlzIG5vdCBzZXQpIHdpdGggY21kLT5ybncgdHJ1ZQph
bmQgY21kLT5kZXN0cyA9PSBOVUxMIHN1Y2NlZWRzLCB0aGUgcmV0cnkgbG9vcCBhYm92ZSBpcyBu
b3cgc2FmZS4gSG93ZXZlciwKZXhlY3V0aW9uIHByb2NlZWRzIHRvIGkzY19jY2NfdmFsaWRhdGVf
cGF5bG9hZF9sZW4oKToKCmRyaXZlcnMvaTNjL21hc3Rlci5jOmkzY19jY2NfdmFsaWRhdGVfcGF5
bG9hZF9sZW4oKSB7CiAgICBpZiAoIWNtZC0+cm53KQogICAgICAgIHJldHVybiAwOwoKICAgIGZv
ciAoaSA9IDA7IGkgPCBjbWQtPm5kZXN0czsgaSsrKSB7CiAgICAgICAgc3RydWN0IGkzY19jY2Nf
Y21kX3BheWxvYWQgKnAgPSAmY21kLT5kZXN0c1tpXS5wYXlsb2FkOwogICAgICAgIC4uLgp9CgpX
aWxsIHRoaXMgcmVzdWx0IGluIHRoZSBleGFjdCBzYW1lIGNyYXNoIHdoZW4gZXZhbHVhdGluZwpj
bWQtPmRlc3RzW2ldLnBheWxvYWQ/CgpBbHNvLCBlYXJsaWVyIGluIGkzY19tYXN0ZXJfc2VuZF9j
Y2NfY21kX2xvY2tlZCgpOgoKICAgIGlmICgoY21kLT5pZCAmIEkzQ19DQ0NfRElSRUNUKSAmJiAo
IWNtZC0+ZGVzdHMgfHwgIWNtZC0+bmRlc3RzKSkKICAgICAgICByZXR1cm4gLUVJTlZBTDsKClRo
aXMgZWFybHkgdmFsaWRhdGlvbiBjaGVjayBvbmx5IGVuZm9yY2VzIGNtZC0+ZGVzdHMgIT0gTlVM
TCBmb3IgRElSRUNUCmNvbW1hbmRzLiBDb3VsZCB0aGlzIGJlIHVwZGF0ZWQgdG8gcmVqZWN0IGFu
eSBjb21tYW5kIHdoZXJlIGNtZC0+ZGVzdHMgaXMKTlVMTCBidXQgY21kLT5uZGVzdHMgPiAwLCBy
YXRoZXIgdGhhbiBwYXRjaGluZyBpbmRpdmlkdWFsIGRlcmVmZXJlbmNlcz8KCi0tIApTYXNoaWtv
IEFJIHJldmlldyDCtyBodHRwczovL3Nhc2hpa28uZGV2LyMvcGF0Y2hzZXQvMjAyNjA3MjgwNjMw
NDUuNzM0NzMtMS16ZW5naG9uZ2xpbmdAa3lsaW5vcy5jbj9wYXJ0PTEKCi0tIApsaW51eC1pM2Mg
bWFpbGluZyBsaXN0CmxpbnV4LWkzY0BsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5p
bmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtaTNjCg==