Re: [PATCH v2 4/7] dt-bindings: reset: Add reset controller constants for mt8167
Krzysztof Kozlowski <[email protected]>
| Newsgroups | org.infradead.lists.linux-mediatek,org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel,org.kernel.vger.linux-watchdog |
|---|---|
| Message-ID | <20260720-authentic-gleeful-asp-20bebd@quoll> |
On Fri, Jul 17, 2026 at 06:39:15PM +0200, Luca Leonardo Scorcia wrote: > Add the various bits that identify watchdog and mmsys resets. IDs for > mmsys resets restart from zero as they are used in a different device. > > Signed-off-by: Luca Leonardo Scorcia <[email protected]> > --- > .../reset/mediatek,mt8167-resets.h | 53 +++++++++++++++++++ I do not see any user of this ABI nor explanation why you are doing it. > 1 file changed, 53 insertions(+) > create mode 100644 include/dt-bindings/reset/mediatek,mt8167-resets.h > > diff --git a/include/dt-bindings/reset/mediatek,mt8167-resets.h b/include/dt-bindings/reset/mediatek,mt8167-resets.h > new file mode 100644 > index 000000000000..85d2d0e99c68 > --- /dev/null > +++ b/include/dt-bindings/reset/mediatek,mt8167-resets.h > @@ -0,0 +1,53 @@ > +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-3-Clause) */ > +#ifndef _DT_BINDINGS_RESET_CONTROLLER_MT8167 > +#define _DT_BINDINGS_RESET_CONTROLLER_MT8167 > + > +/* TOPRGU resets, these are actual bits in the register */ > +#define MT8167_TOPRGU_DDRPHY_FLASH_RST 0 > +#define MT8167_TOPRGU_AUD_PAD_RST 1 > +#define MT8167_TOPRGU_MM_RST 2 > +#define MT8167_TOPRGU_MFG_RST 3 > +#define MT8167_TOPRGU_MDSYS_RST 4 > +#define MT8167_TOPRGU_CONN_RST 5 > +#define MT8167_TOPRGU_PAD2CAM_DIG_MIPI_RX_RST 6 > +#define MT8167_TOPRGU_DIG_MIPI_TX_RST 7 > +#define MT8167_TOPRGU_SPI_PAD_MACRO_RST 8 > +/* bit 9 is reserved, unused according to data sheet */ NAK, how driver can reserve something? Fix your driver. This is ABI for Linux driver. Best regards, Krzysztof