Re: [PATCH 1/4] pinctrl: airoha: Remove redundant dev_err()
Lorenzo Bianconi <[email protected]>
| Newsgroups | org.infradead.lists.linux-mediatek,org.kernel.vger.linux-gpio,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <al4CsgKsPOjLbMOG@lore-desk> |
> Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
> devm_request_*_irq()"), devm_request_irq() automatically logs
> detailed error messages on failure. Remove the now-redundant
> driver-specific dev_err() calls.
>
> Signed-off-by: Pan Chuang <[email protected]>
Acked-by: Lorenzo Bianconi <[email protected]>
> ---
> drivers/pinctrl/airoha/pinctrl-airoha.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/pinctrl/airoha/pinctrl-airoha.c b/drivers/pinctrl/airoha/pinctrl-airoha.c
> index 04b4424c688b..abfb018f207e 100644
> --- a/drivers/pinctrl/airoha/pinctrl-airoha.c
> +++ b/drivers/pinctrl/airoha/pinctrl-airoha.c
> @@ -2519,10 +2519,8 @@ static int airoha_pinctrl_add_gpiochip(struct airoha_pinctrl *pinctrl,
>
> err = devm_request_irq(dev, irq, airoha_irq_handler, IRQF_SHARED,
> dev_name(dev), pinctrl);
> - if (err) {
> - dev_err(dev, "error requesting irq %d: %d\n", irq, err);
> + if (err)
> return err;
> - }
>
> return devm_gpiochip_add_data(dev, gc, pinctrl);
> }
> --
> 2.34.1
>
signature.asc
(application/pgp-signature, 228 B)
-----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCal4CsgAKCRA6cBh0uS2t rHN/AP9WOMMqAKBkonIPmZJjNZHnygVO1hiEz0O2OzJGOpC/rQD/VbXrG4odBVqc +qAQn+JF55oPPslgw2SiHZTDmMgpDQs= =0x8e -----END PGP SIGNATURE-----