Re: [PATCH v2 2/2] thermal/drivers/mediatek/lvts_thermal: Make reset optional for MT8196
Chen-Yu Tsai <[email protected]>
| Newsgroups | org.infradead.lists.linux-mediatek,org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel,org.kernel.vger.linux-pm |
|---|---|
| Message-ID | <CAGXv+5GrPZCZ=jNRi1AtduyZoB8DF_FUZev2CXhu4WzGri6U3A@mail.gmail.com> |
On Tue, Jul 21, 2026 at 6:52 PM AngeloGioacchino Del Regno <[email protected]> wrote: > > Depending on the SoC+Firmware combination, the LVTS hardware may be > may be actively used by one or even multiple concurrent MCUs! > In this case, resetting it may produce either a severe slowdown of > the entire system, or even a thermal protection AP reset, as some > MCU(s) may be reading a very high or very low temperature while the > LVTS is being reset. > > On those, don't fail if no reset is found as that may be omitted on > purpose, but still check if there's one, because some board(s) may > be running on a different bootchain with reduced firmwares or using > firmwares with reduced functionality. > > So, use devm_reset_control_get_optional_exclusive() instead, as the > LVTS controller always had only one reset and retrieving that by > index, specifically, always made little sense anyway. > > Signed-off-by: AngeloGioacchino Del Regno <[email protected]> Reviewed-by: Chen-Yu Tsai <[email protected]>