Re: [PATCH net-next v10 0/3] airoha: add the capability to configure GDM3/GDM4 as WAN/LAN on demand

Lorenzo Bianconi <[email protected]>
Newsgroups org.infradead.lists.linux-mediatek,org.infradead.lists.linux-arm-kernel,org.kernel.vger.netdev
Message-ID <amNlP37tMJYp-Hdp@lore-desk>
> Add the capability to configure GDM3/GDM4 as WAN/LAN on demand when QoS
> offload is created or destroyed.
> Make dev->qdma an RCU pointer so the TX path can safely dereference it
> without holding RTNL.
> Introduce airoha_qdma_start() and airoha_qdma_stop() helpers.

please drop this series, I will post a new one to address sashiko's comments.

Regards,
Lorenzo

> 
> ---
> Changes in v10:
> - Fix a theoretical race condition between tx completion NAPIs moving the
>   net_device between different QDMA.
> - Rebase on top of next-next main branch
> - Link to v9: https://lore.kernel.org/r/[email protected]
> 
> Changes in v9:
> - Rebase on top of next-next main branch
> - Link to v8: https://lore.kernel.org/r/[email protected]
> 
> Changes in v8:
> - Rebase on top of next-next to fix conflicts.
> - Link to v7: https://lore.kernel.org/r/[email protected]
> 
> Changes in v7:
> - Fix ETS stats accounting in patch 2/3
> - Reset ETS stats accounting in airoha_dev_set_qdma().
> - Link to v6: https://lore.kernel.org/r/[email protected]
> 
> Changes in v6:
> - Rebase on top of next-next
> - Add patch 1/3: "rename airoha_priv_flags to airoha_dev_flags"
> - Drop patch 2/3: "refactor QDMA start/stop into reusable helpers"
> - Link to v5: https://lore.kernel.org/r/[email protected]
> 
> Changes in v5:
> - Add patch 1/3: use int instead of atomic_t for qdma users counter
> - Protect dev->flags with flow_offload_mutex mutex.
> - Introduce AIROHA_PRIV_F_QOS in order to handle better WAN/LAN
>   switching.
> - Link to v4: https://lore.kernel.org/r/[email protected]
> 
> Changes in v4:
> - Move back QDMA TX/RX DMA enable to airoha_dev_open()/airoha_dev_stop().
> - Configure GDM3/4 as WAN if GDM2 is not available in ndo_init()
>   callback.
> - Protect qdma pointer in airoha_gdm_dev struct using RCU.
> - Rely on rtnl_dereference() to access qdma pointer in the control path.
> - Add airoha_qdma_start() and airoha_qdma_stop() utility routines in
>   patch 1/2
> - Link to v3: https://lore.kernel.org/r/[email protected]
> 
> Changes in v3:
> - Do not introduce ethtool private flags support to configure LAN/WAN
>   for GDM3/4 and rely on tc qdisc offload for it instead.
> - Set GDM3/4 ports as LAN by default.
> - Move QDMA TX/RX DMA enable from airoha_dev_open() to airoha_probe()
>   and the corresponding disable from airoha_dev_stop() to airoha_qdma_cleanup().
> - Link to v2: https://lore.kernel.org/r/[email protected]
> 
> Changes in v2:
> - Rework airoha_dev_set_wan_flag routine
> - Enable GDM_STRIP_CRC_MASK in airoha_disable_gdm2_loopback()
> - Do not always reset REG_SRC_PORT_FC_MAP6 in
>   airoha_disable_gdm2_loopback() but use the same condition used in
>   airoha_enable_gdm2_loopback().
> - Link to v1: https://lore.kernel.org/r/[email protected]
> 
> ---
> Lorenzo Bianconi (3):
>       net: airoha: rename airoha_priv_flags to airoha_dev_flags
>       net: airoha: fix ETS QoS stats counter underflow and cross-channel corruption
>       net: airoha: defer GDM3/GDM4 WAN mode and GDM2 loopback to QoS offload
> 
>  drivers/net/ethernet/airoha/airoha_eth.c  | 268 ++++++++++++++++++++++++++----
>  drivers/net/ethernet/airoha/airoha_eth.h  |  26 ++-
>  drivers/net/ethernet/airoha/airoha_ppe.c  |   9 +-
>  drivers/net/ethernet/airoha/airoha_regs.h |   1 +
>  4 files changed, 261 insertions(+), 43 deletions(-)
> ---
> base-commit: 88f380ef2304db4c68bc4bf14fc6c1604f6dd15c
> change-id: 20260606-airoha-ethtool-priv_flags-b6aa70caa780
> 
> Best regards,
> -- 
> Lorenzo Bianconi <[email protected]>
>
signature.asc (application/pgp-signature, 228 B)
-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCamNlPwAKCRA6cBh0uS2t
rEbXAP9TBPic+WUY6BAE3Sm9oho1WMIYlT3puIgnWd3RElBQ/gD+Jdf77Dl8gaTl
VrsmBh/aVrCEQ668SmmVAkE08mphpwo=
=+Bwn
-----END PGP SIGNATURE-----
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.