Re: [PATCH v7 04/34] pinctrl: airoha: an7581: fix misprint in bitfield name

Lorenzo Bianconi <[email protected]>
Newsgroups org.infradead.lists.linux-mediatek,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-gpio,org.kernel.vger.linux-kernel
Message-ID <amcNrSeVi2oiOQUp@lore-desk>
> Fix misprint in bitfield name of GPIO_2ND_I2C_MODE register
> 
> Fixes: 1c8ace2d0725 ("pinctrl: airoha: Add support for EN7581 SoC")
> Signed-off-by: Mikhail Kshevetskiy <[email protected]>

Acked-by: Lorenzo Bianconi <[email protected]>

I guess you can fix GPIO_I2C_MASTER_MODE_MODE too.

Regards,
Lorenzo

> ---
>  drivers/pinctrl/airoha/pinctrl-airoha.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/pinctrl/airoha/pinctrl-airoha.c b/drivers/pinctrl/airoha/pinctrl-airoha.c
> index abfb018f207e5..a3cfee6ace778 100644
> --- a/drivers/pinctrl/airoha/pinctrl-airoha.c
> +++ b/drivers/pinctrl/airoha/pinctrl-airoha.c
> @@ -49,7 +49,7 @@
>  
>  /* MUX */
>  #define REG_GPIO_2ND_I2C_MODE			0x0214
> -#define GPIO_MDC_IO_MASTER_MODE_MODE		BIT(14)
> +#define GPIO_MDC_IO_MASTER_MODE_MASK		BIT(14)
>  #define GPIO_I2C_MASTER_MODE_MODE		BIT(13)
>  #define GPIO_I2S_MODE_MASK			BIT(12)
>  #define GPIO_I2C_SLAVE_MODE_MODE		BIT(11)
> @@ -1026,8 +1026,8 @@ static const struct airoha_pinctrl_func_group mdio_func_group[] = {
>  		.regmap[0] = {
>  			AIROHA_FUNC_MUX,
>  			REG_GPIO_2ND_I2C_MODE,
> -			GPIO_MDC_IO_MASTER_MODE_MODE,
> -			GPIO_MDC_IO_MASTER_MODE_MODE
> +			GPIO_MDC_IO_MASTER_MODE_MASK,
> +			GPIO_MDC_IO_MASTER_MODE_MASK
>  		},
>  		.regmap[1] = {
>  			AIROHA_FUNC_MUX,
> @@ -1051,8 +1051,8 @@ static const struct airoha_pinctrl_func_group an7583_mdio_func_group[] = {
>  		.regmap[1] = {
>  			AIROHA_FUNC_MUX,
>  			REG_GPIO_SPI_CS1_MODE,
> -			GPIO_MDC_IO_MASTER_MODE_MODE,
> -			GPIO_MDC_IO_MASTER_MODE_MODE
> +			GPIO_MDC_IO_MASTER_MODE_MASK,
> +			GPIO_MDC_IO_MASTER_MODE_MASK
>  		},
>  		.regmap_size = 2,
>  	},
> -- 
> 2.53.0
>
signature.asc (application/pgp-signature, 228 B)
-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCamcNrQAKCRA6cBh0uS2t
rBUpAP9NVeQoqX1obrWad58aOK2MAb6Ni7VTWYq6c5L9azHCMAEAztx97agV+lsZ
iEI1NU5G8HzeXnVSthu3pVqrNS36Eg0=
=A+h4
-----END PGP SIGNATURE-----
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.