[PATCH v10 11/26] scsi: ufs: mediatek: Remove undocumented downstream reset cruft
Louis-Alexis Eyraud <[email protected]> Thu, 30 Jul 2026 11:49:07 +0200
| Newsgroups | org.infradead.lists.linux-mediatek,org.infradead.lists.linux-arm-kernel,org.infradead.lists.linux-phy,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel,org.kernel.vger.linux-scsi |
|---|---|
| Message-ID | <[email protected]> |
From: Nicolas Frattaroli <[email protected]> The MediaTek UFS host driver's probe function allows using a ti,syscon-reset as a reset, without going through the appropriate abstractions, or by documenting this in the binding at all. Remove this, it's downstream code and does not belong here. Reviewed-by: AngeloGioacchino Del Regno <[email protected]> Signed-off-by: Nicolas Frattaroli <[email protected]> Signed-off-by: Louis-Alexis Eyraud <[email protected]> --- drivers/ufs/host/ufs-mediatek.c | 33 +++------------------------------ 1 file changed, 3 insertions(+), 30 deletions(-) diff --git a/drivers/ufs/host/ufs-mediatek.c b/drivers/ufs/host/ufs-mediatek.c index 65036c839031..a2749e79514c 100644 --- a/drivers/ufs/host/ufs-mediatek.c +++ b/drivers/ufs/host/ufs-mediatek.c @@ -2402,38 +2402,12 @@ MODULE_DEVICE_TABLE(of, ufs_mtk_of_match); static int ufs_mtk_probe(struct platform_device *pdev) { int err; - struct device *dev = &pdev->dev, *phy_dev = NULL; - struct device_node *reset_node, *phy_node = NULL; - struct platform_device *reset_pdev, *phy_pdev = NULL; - struct device_link *link; struct ufs_hba *hba; + struct platform_device *phy_pdev = NULL; + struct device *dev = &pdev->dev, *phy_dev = NULL; + struct device_node *phy_node = NULL; struct ufs_mtk_host *host; - reset_node = of_find_compatible_node(NULL, NULL, - "ti,syscon-reset"); - if (!reset_node) { - dev_notice(dev, "find ti,syscon-reset fail\n"); - goto skip_reset; - } - reset_pdev = of_find_device_by_node(reset_node); - if (!reset_pdev) { - dev_notice(dev, "find reset_pdev fail\n"); - goto skip_reset; - } - link = device_link_add(dev, &reset_pdev->dev, - DL_FLAG_AUTOPROBE_CONSUMER); - put_device(&reset_pdev->dev); - if (!link) { - dev_notice(dev, "add reset device_link fail\n"); - goto skip_reset; - } - /* supplier is not probed */ - if (link->status == DL_STATE_DORMANT) { - err = -EPROBE_DEFER; - goto out; - } - -skip_reset: /* find phy node */ phy_node = of_parse_phandle(dev->of_node, "phys", 0); @@ -2479,7 +2453,6 @@ static int ufs_mtk_probe(struct platform_device *pdev) out: of_node_put(phy_node); - of_node_put(reset_node); return err; } -- 2.55.0