Re: [PATCH v3 1/4] ASoC: dt-bindings: Add Airoha AN7581 AFE Sound card.

On Sun, May 31, 2026 at 02:39:32PM +0200, Krzysztof Kozlowski wrote:
> On Thu, May 28, 2026 at 07:48:29PM +0200, Christian Marangi wrote:
> > Add YAML schema for Airoha AN7581 AFE SoC sound card.
> >
> 
> Nit: subject, drop final stop.
> 
> 
> > Signed-off-by: Christian Marangi <[email protected]>
> > ---
> >  .../bindings/sound/airoha,an7581-afe.yaml     | 41 +++++++++++++++++++
> >  1 file changed, 41 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/sound/airoha,an7581-afe.yaml
> > 
> > diff --git a/Documentation/devicetree/bindings/sound/airoha,an7581-afe.yaml b/Documentation/devicetree/bindings/sound/airoha,an7581-afe.yaml
> > new file mode 100644
> > index 000000000000..80d9e87f1470
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/sound/airoha,an7581-afe.yaml
> > @@ -0,0 +1,41 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/sound/airoha,an7581-afe.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Airoha AFE PCM controller for AN7581
> > +
> > +maintainers:
> > +  - Christian Marangi <[email protected]>
> > +
> > +properties:
> > +  compatible:
> > +    const: airoha,an7581-afe
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  interrupts:
> > +    maxItems: 1
> 
> This looks incomplete - missing at least clocks. Are you sure that AFE
> here is so limited, comparing to other Mediatek designs?
>

Sorry for the late reply, I checked documentation and the SoC doesn't have
a clock for AFE, Airoha reported that it's always enable from reset
condition. The clock driver doesn't expose it.
 
> 

-- 
	Ansuel