Re: [PATCH net-next] net: phy: mediatek: add EcoNet EN7528 PHY support

On Tue, Aug 04, 2026 at 02:33:21PM +0400, Ahmed Naseef wrote:
> The EcoNet EN7528 MIPS SoC embeds four Gigabit Ethernet PHYs (PHY ID
> 0x03a29491) behind its built-in MT7530 switch. They use the same LED
> register layout as the other SoC PHYs handled by this driver, but their
> LED controller powers up with its external control disabled, so the LED
> pins stay dark regardless of what is programmed into the LED control
> registers.
> 
> Add a phy_driver entry for it, modelled on the Airoha AN7583 one. Its
> config_init callback enables the LED controller through the LED basic
> control register, which this driver does not program for its other
> PHYs, but which the air_en8811h driver already handles as
> AIR_PHY_LED_BCR. LED behaviour is then controlled through the phylib
> LED operations shared with the other PHYs of this driver.
> 
> The LED block is shared by the four PHYs of the EN7528: the LED
> configuration programmed through any one of them applies to all four,
> while each PHY still drives its own LED pin from its own link state.
> 
> The EN7528 PHYs need no efuse calibration data, so relax the
> MEDIATEK_GE_SOC_PHY dependencies to allow building the driver on the
> ECONET platform.
> 
> Signed-off-by: Ahmed Naseef <[email protected]>

Reviewed-by: Andrew Lunn <[email protected]>

    Andrew