Re: [PATCH v8 30/35] dt-bindings: pinctrl: airoha: an7583: add olt function/group

On 7/27/26 23:15, Krzysztof Kozlowski wrote:
> On Mon, Jul 27, 2026 at 08:41:36PM +0300, Mikhail Kshevetskiy wrote:
>> Add support for olt pin function for olt pin group.
>>
>> Signed-off-by: Mikhail Kshevetskiy <[email protected]>
>> ---
>>  .../bindings/pinctrl/airoha,an7583-pinctrl.yaml        | 10 +++++++++-
>>  1 file changed, 9 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/pinctrl/airoha,an7583-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/airoha,an7583-pinctrl.yaml
>> index 7deb48db52c3a..f016e0da65a57 100644
>> --- a/Documentation/devicetree/bindings/pinctrl/airoha,an7583-pinctrl.yaml
>> +++ b/Documentation/devicetree/bindings/pinctrl/airoha,an7583-pinctrl.yaml
>> @@ -60,7 +60,7 @@ patternProperties:
>>            function:
>>              description:
>>                A string containing the name of the function to mux to the group.
>> -            enum: [pon, tod_1pps, sipo, mdio, uart, jtag, pcm, spi,
>> +            enum: [pon, olt, tod_1pps, sipo, mdio, uart, jtag, pcm, spi,
> You just changed this line in previous patch, no?
>
> Why binding patches are spread all over instead of properly grouped?
> This makes it difficult to review. Please read submitting patches (both documents).

I tried to create a separate binding patch per change. Could you clarify
your suggestion?

> Best regards,
> Krzysztof
>