Re: [PATCH v10 31/36] dt-bindings: pinctrl: airoha: an7583: add missed features
Krzysztof Kozlowski <[email protected]> Thu, 6 Aug 2026 09:12:09 +0200
| Newsgroups | org.infradead.lists.linux-mediatek,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-gpio,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <20260806-muscular-tench-of-elegance-8ec390@quoll> |
On Wed, Aug 05, 2026 at 03:34:03PM +0300, Mikhail Kshevetskiy wrote: > Changes: > * add i2c0 pin-group support for i2c pin-function > * add npu_uart pin-group support for uart pin-function > * add pon_alt pin-group support for pon pin-function > * add support for olt pin group/function > > Signed-off-by: Mikhail Kshevetskiy <[email protected]> > --- > .../bindings/pinctrl/airoha,an7583-pinctrl.yaml | 16 ++++++++++++---- > 1 file changed, 12 insertions(+), 4 deletions(-) This is still incorrectly organized. Please organize the patch documenting the bindings before the patch using them. See also: https://elixir.bootlin.com/linux/v6.14-rc6/source/Documentation/devicetree/bindings/submitting-patches.rst#L46 With this fixed: Reviewed-by: Krzysztof Kozlowski <[email protected]> Best regards, Krzysztof