Re: [PATCH net] net: phy: mediatek: fix TX blink masks using the RX bits
[email protected] Thu, 06 Aug 2026 13:00:05 +0000
| Newsgroups | org.infradead.lists.linux-mediatek,org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-kernel,org.kernel.vger.netdev |
|---|---|
| Message-ID | <178602120563.832117.16144265633708146287.git-patchwork-notify@kernel.org> |
Hello: This patch was applied to netdev/net.git (main) by Paolo Abeni <[email protected]>: On Tue, 4 Aug 2026 15:35:11 +0400 you wrote: > MTK_GPHY_LED_TX_BLINK_SET and MTK_2P5GPHY_LED_TX_BLINK_SET are built > from the RX blink bits instead of the TX ones, so both TX masks are > identical to their RX counterparts. The TX bits they should be using, > MTK_PHY_LED_BLINK_{10,100,1000,2500}TX, are otherwise only referenced > by the per-speed branch of mtk_phy_led_hw_ctrl_set(). > > A TX trigger selected without a link trigger therefore programs the RX > blink bits, and the LED blinks on received traffic. The masks are also > used to decode the blink register in mtk_phy_led_hw_ctrl_get(), which > as a result cannot tell the two triggers apart: an RX-only > configuration reads back as RX and TX, and a TX-only configuration > reads back as neither. > > [...] Here is the summary with links: - [net] net: phy: mediatek: fix TX blink masks using the RX bits https://git.kernel.org/netdev/net/c/f684c514f796 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html