Re: [PATCH net] net: dsa: mt7530: do not advertise EEE on MT7621 switch
Benjamin Larsson <[email protected]>
| Newsgroups | org.infradead.lists.linux-mediatek,org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-kernel,org.kernel.vger.netdev |
|---|---|
| Message-ID | <[email protected]> |
Hi.
On 18/08/2026 20:42, Daniel Golle wrote:
> Hi,
>
>
> It'd be very surprising if this limitation doesn't also apply for the
> nearly identical decicated MT7530 IC (found eg. on BananaPi R2).
>
> I'd recommend disabling EEE advertisement on MT7621 and MT7530; and I
> suspect that some of the older Trendnet/Econet SoCs which share common
> linage with the MediaTek's Ethernet switch and PHY designs could also
> be affected.
The phy should be similar to Vitesse also.
>
> Hence I'd suggest to extend 'struct mt753x_info' with a 'broken_eee'
> bool instead of maintining an in-code list of EEE-broken silicon IDs.
>
>> + /* Disable EEE advertisement on the switch PHYs. */
>> + for (i = MT753X_CTRL_PHY_ADDR(priv->mdiodev->addr);
>> + i < MT753X_CTRL_PHY_ADDR(priv->mdiodev->addr) + MT7530_NUM_PHYS;
>> + i++) {
>> + mt7530_phy_write_c45(priv, i, MDIO_MMD_AN, MDIO_AN_EEE_ADV, 0);
>> + }
>> + }
>> +
>
>
MvH
Benjamin Larsson