Re: [PATCH 2/4] ASoC: mediatek: mt8183: Fix APLL enable error handling
Mark Brown <[email protected]>
| Newsgroups | org.infradead.lists.linux-mediatek,org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-kernel,org.kernel.vger.linux-sound |
|---|---|
| Message-ID | <[email protected]> |
On Wed, Aug 19, 2026 at 05:18:47PM +0700, [email protected] wrote: > From: bui duc phuc <[email protected]> > > Currently, the mt8183_apll*_enable() functions call mux_setting(afe, true) > but do not check its return value to handle failures. > > In addition, the cleanup paths of mt8183_apll*_enable() do not call > mux_setting(afe, false) when the enable operation fails, while the > mt8183_apll*_disable() functions do. > > Add error handling for apll*_mux_setting() and call mux_setting(afe, false) > in the cleanup paths when mt8183_apll*_enable() fails. > - apll1_mux_setting(afe, true); > + ret = apll1_mux_setting(afe, true); > + if (ret) { > + dev_err(afe->dev, "%s apll1_mux_setting fail %d\n", > + __func__, ret); > + goto ERR_APLL1_MUX_SETTING; > + } apll1_mux_setting() logs errors, do we need to add another log?
signature.asc
(application/pgp-signature, 488 B)
-----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmqF1DAACgkQJNaLcl1U h9DXtAf+MNuno9lo4ZsotXg9MOl9pnhUb2KfgvrIvkNu4j4j2CbqJoFi1hMugT8v GqW9yNgjbPMzJ/Of5sgmWc9keOc4bcVDhewHaKFMa+bKOVmyJ54lcu5PPQ9EYUQk vdoK9uKUB3eVKWZeOPC0DyyEEP+BOEUt/oqTBPMdlV2hE1hIoMf38j1rEeEBaqID 0kPr7CIi9H9Et3KmDcHVXX+VCTWR8OXpeR6ZHIDbRPnGlCe9kvYYIINkuRntT7kj dpY6zArUsNBY6TC+XoUlwBln+WR1nTcdifXa1jfVF80RrwMn1EyqR5CHRo86/1oT M+nJS19pFmGbOWnSVN59/ox9/+TIoA== =YBEO -----END PGP SIGNATURE-----