Re: [PATCH 2/4] ASoC: mediatek: mt8183: Fix APLL enable error handling
Bui Duc Phuc <[email protected]>
| Newsgroups | org.infradead.lists.linux-mediatek,org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-kernel,org.kernel.vger.linux-sound |
|---|---|
| Message-ID | <CAABR9nF1VaUKeUDhJydJYYc_Jc0kdYCdD3+rtLNR2SPCx9RPbg@mail.gmail.com> |
Hi Mark,
Thank you for your review.
> > - apll1_mux_setting(afe, true);
> > + ret = apll1_mux_setting(afe, true);
> > + if (ret) {
> > + dev_err(afe->dev, "%s apll1_mux_setting fail %d\n",
> > + __func__, ret);
> > + goto ERR_APLL1_MUX_SETTING;
> > + }
>
> apll1_mux_setting() logs errors, do we need to add another log?
Oh, sorry, this was an oversight on my part. The apll1_mux_setting()
function already logs the error,
so there is no need to add another error message here.
I’ll send v2 shortly.
Best regards,
Phuc