Re: [PATCH v2 1/3] ASoC: mediatek: mt6797: fix wrong unwind order and error code in enable_clock

Bui Duc Phuc <[email protected]> Thu, 20 Aug 2026 18:21:55 +0700

Newsgroups	org.infradead.lists.linux-mediatek,org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-kernel,org.kernel.vger.linux-sound
Message-ID	<CAABR9nFcw+hZhUKCMkgs+L0JHJqFSKw9OQRFUm9e3pmNqmAg0A@mail.gmail.com>

Hi Cezary,

Thank you for your review.

>
> There is no changelog in this series so reviewers have harder job
> analyzing the v2 patches. If there is no cover-letter, you can always
> paste the update here, after '---'.
>

> In regard to the patch, the fix looks good - given the number of errors
> in the existing code with invalid return code on top, perhaps someone
> wanted the function to be permissive.
>
> Otherwise it's just bunch of untested stuff and your change should be
> tagged with: Fixes: and propagated downstream.
>
> Reviewed-by: Cezary Rojewski <[email protected]>

I’ll add the Fixes: tag and include a changelog
for the changes in the next revision.

Best regards,
Phuc