Re: [PATCH 33/45] clk: spear: Make sure clk_init_data is fully initialized
Viresh Kumar <[email protected]>
| Newsgroups | org.infradead.lists.linux-mediatek,dev.linux.lists.imx,dev.linux.lists.linux-sunxi,dev.linux.lists.soc,org.kernel.vger.arm-scmi,org.kernel.vger.linux-clk,org.kernel.vger.linux-kernel,org.kernel.vger.linux-mips,org.kernel.vger.linux-renesas-soc,org.kernel.vger.linux-samsung-soc,org.kernel.vger.linux-tegra,org.ozlabs.lists.linux-aspeed,org.ozlabs.lists.openbmc |
|---|---|
| Message-ID | <aovDOSMKhHLI70dW@vireshk-B250M-D3H> |
On 21-08-26, 10:53, Geert Uytterhoeven wrote: > The clk_init_data structure contains several mutually-exclusive members > for different methods to specify the possible parents of a clock, > prompting drivers to initialize only the members they need. However, > not initializing all members may cause subtle issues, which are only > exposed when CONFIG_INIT_STACK_ALL_PATTERN or CONFIG_INIT_STACK_NONE is > enabled. > > Make sure all members are fully initialized, to avoid such bugs, and to > prevent future breakage when converting drivers to a different method > for specifying the parents. > > Signed-off-by: Geert Uytterhoeven <[email protected]> > --- > Compile-tested only. > --- > drivers/clk/spear/clk-aux-synth.c | 2 +- > drivers/clk/spear/clk-frac-synth.c | 2 +- > drivers/clk/spear/clk-gpt-synth.c | 2 +- > drivers/clk/spear/clk-vco-pll.c | 2 +- > 4 files changed, 4 insertions(+), 4 deletions(-) Acked-by: Viresh Kumar <[email protected]> -- viresh