Re: [PATCH] mtd: spi-nor: xmc: Add XM25QH128C identification

--===============2963010445394613472==
Content-Type: multipart/signed;
 boundary=15ddd975892464ec2512ad69e1d711e7c4c28f4c1d5f4535782946b14ef8;
 micalg=pgp-sha384; protocol="application/pgp-signature"

--15ddd975892464ec2512ad69e1d711e7c4c28f4c1d5f4535782946b14ef8
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8

Hi Fabio,

On Mon Jul 20, 2026 at 8:43 PM CEST, Fabio Estevam wrote:
> On Monday, July 20, 2026 03:45 -03, "Michael Walle" <[email protected]> w=
rote:
>
>> So why do you need an entry? We don't add .names on new entries.
>
> Currently, I see:
>
> root@rk3399-station-p1:~# cat /sys/bus/spi/devices/spi1.0/spi-nor/partnam=
e
> spi-nor-generic
> root@rk3399-station-p1:~# cat /sys/bus/spi/devices/spi1.0/spi-nor/jedec_i=
d
> 204018204018
> root@rk3399-station-p1:~# cat /sys/bus/spi/devices/spi1.0/spi-nor/manufac=
turer
> cat: /sys/bus/spi/devices/spi1.0/spi-nor/manufacturer: No such file or di=
rectory
> root@rk3399-station-p1:~#=20
>
> After this patch:
>
> root@rk3399-station-p1:~# cat /sys/bus/spi/devices/spi1.0/spi-nor/partnam=
e
> XM25QH128C
> root@rk3399-station-p1:~# cat /sys/bus/spi/devices/spi1.0/spi-nor/jedec_i=
d
> 204018
> root@rk3399-station-p1:~# cat /sys/bus/spi/devices/spi1.0/spi-nor/manufac=
turer
> xmc
>
> The advantage of this patch is to provide the partname and manufacturer e=
ntries for userspace.

Yeah I get that, but since vendors tend to reuse their flash ids for
different parts, the part name is useless (and probably wrong) most
of the time. The idea was to just expose the id nowadays and if you
really need the flash part name, it's the duty of an userspace
application to figure that out.

-michael

>
> If this is not wanted, feel free to discard this change.


--15ddd975892464ec2512ad69e1d711e7c4c28f4c1d5f4535782946b14ef8
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iKgEABMJADAWIQTIVZIcOo5wfU/AngkSJzzuPgIf+AUCal8yGhIcbXdhbGxlQGtl
cm5lbC5vcmcACgkQEic87j4CH/ixmQGAlPRrfEuceAX1KmTF4RRDvsUB1LYaTtWv
xBGay4FLxNAInBMxKszTnLIcALxmKsnbAX9XSgdk3zZyt1ACJjkBJcN6SgIotQq7
w6ngOjZHVGaCMwN5Fp8EpAmpfq6qVEeU25s=
=Xe/u
-----END PGP SIGNATURE-----

--15ddd975892464ec2512ad69e1d711e7c4c28f4c1d5f4535782946b14ef8--


--===============2963010445394613472==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

--===============2963010445394613472==--