[PATCH v2 06/18] mtd: spi-nor: winbond: Drop the .name entry of JV chips
Miquel Raynal <[email protected]>
| Newsgroups | org.infradead.lists.linux-mtd,org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-doc,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <20260807-winbond-v7-1-spi-nor-rv-addition-v2-6-7797642dfc40@bootlin.com> |
This is a legacy field. It is often incorrectly filled and will soon become very inconsistent due to IDs being reused. As an example, chips ending with JV-Q or JV-N and soon RV-Q and RV-N all share the same ID. There are comments above the fields which already list the correct names being supported by a single entry. The names not being part of any stable ABI (they are not displayed through sysfs, which only shows the mtd name being spi-norX.Y), they are only available through debugfs, so let's just drop that field when it becomes a problem. Signed-off-by: Miquel Raynal <[email protected]> --- drivers/mtd/spi-nor/winbond.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/drivers/mtd/spi-nor/winbond.c b/drivers/mtd/spi-nor/winbond.c index 01a693033448..88fdcfeb6eff 100644 --- a/drivers/mtd/spi-nor/winbond.c +++ b/drivers/mtd/spi-nor/winbond.c @@ -200,14 +200,12 @@ static const struct flash_info winbond_nor_parts[] = { }, { /* W25Q32JV-Q/N */ .id = SNOR_ID(0xef, 0x40, 0x16), - .name = "w25q32", .size = SZ_4M, .no_sfdp_flags = SECT_4K, .flags = SPI_NOR_QUAD_PP | SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB | SPI_NOR_HAS_CMP, }, { /* W25Q64JV-Q/N */ .id = SNOR_ID(0xef, 0x40, 0x17), - .name = "w25q64", .size = SZ_8M, .no_sfdp_flags = SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ, .flags = SPI_NOR_QUAD_PP | SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB | SPI_NOR_HAS_CMP, @@ -223,7 +221,6 @@ static const struct flash_info winbond_nor_parts[] = { }, { /* W25Q256JV-Q/N */ .id = SNOR_ID(0xef, 0x40, 0x19), - .name = "w25q256", .size = SZ_32M, .no_sfdp_flags = SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ, .flags = SPI_NOR_QUAD_PP | SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB | @@ -232,7 +229,6 @@ static const struct flash_info winbond_nor_parts[] = { }, { /* W25Q512JV-Q/N */ .id = SNOR_ID(0xef, 0x40, 0x20), - .name = "w25q512jvq", .size = SZ_64M, .no_sfdp_flags = SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ, .flags = SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB | SPI_NOR_TB_SR_BIT6 | @@ -304,35 +300,30 @@ static const struct flash_info winbond_nor_parts[] = { }, { /* W25Q16JV-M */ .id = SNOR_ID(0xef, 0x70, 0x15), - .name = "w25q16jv-im/jm", .size = SZ_2M, .no_sfdp_flags = SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ, .flags = SPI_NOR_QUAD_PP | SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB | SPI_NOR_HAS_CMP, }, { /* W25Q32JV-M */ .id = SNOR_ID(0xef, 0x70, 0x16), - .name = "w25q32jv", .size = SZ_4M, .no_sfdp_flags = SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ, .flags = SPI_NOR_QUAD_PP | SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB | SPI_NOR_HAS_CMP, }, { /* W25Q64JV-M */ .id = SNOR_ID(0xef, 0x70, 0x17), - .name = "w25q64jvm", .size = SZ_8M, .no_sfdp_flags = SECT_4K, .flags = SPI_NOR_QUAD_PP | SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB | SPI_NOR_HAS_CMP, }, { /* W25Q128JV-M */ .id = SNOR_ID(0xef, 0x70, 0x18), - .name = "w25q128jv", .size = SZ_16M, .no_sfdp_flags = SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ, .flags = SPI_NOR_QUAD_PP | SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB | SPI_NOR_HAS_CMP, }, { /* W25Q256JV-M */ .id = SNOR_ID(0xef, 0x70, 0x19), - .name = "w25q256jvm", .flags = SPI_NOR_QUAD_PP | SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB | SPI_NOR_TB_SR_BIT6 | SPI_NOR_4BIT_BP | SPI_NOR_HAS_CMP, }, { -- 2.54.0 ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/