Re: [PATCH] nvmetcli: store DHCHAP attributes
Hannes Reinecke <[email protected]>
| Newsgroups | org.infradead.lists.linux-nvme |
|---|---|
| Message-ID | <[email protected]> |
On 7/13/26 2:16 PM, Daniel Wagner wrote: > Hi Hannes, > > On Mon, Jul 13, 2026 at 12:46:57PM +0200, Hannes Reinecke wrote: >> From: Hannes Reinecke <[email protected]> >> >> The DHCHAP authentication is stored under hosts/, and are starting >> with 'dhchap_'. So add a 'dhchap' attribute group for the host object >> to correctly save and restore DHCHAP values. >> >> Signed-off-by: Hannes Reinecke <[email protected]> >> --- >> nvmet/nvme.py | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/nvmet/nvme.py b/nvmet/nvme.py >> index faf1eb2..80d3953 100644 >> --- a/nvmet/nvme.py >> +++ b/nvmet/nvme.py >> @@ -1013,6 +1013,7 @@ class Host(CFSNode): >> ''' >> super(Host, self).__init__() >> >> + self.attr_groups = ['dhchap'] > > Would you mind also extend the test case? > Sure. Will be looking into it. Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect [email protected] +49 911 74053 688 SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich