Re: [PATCH v3 2/2] nvme: fix cdev lifetime

On 7/13/26 4:12 PM, John Garry wrote:
> Fix the lifetime for the cdev by making adding the cdev add take a
> reference to the NS head and drop that reference in the
> nvme_ns_head.cdev_device release function.
> 
> The same problem exists for the NS cdev lifetime, so resolve that issue
> through a similar method by taking a reference to the NS for the lifetime
> of the cdev. Note that nvme_ns_chr_open() -> nvme_ns_open() also takes a
> reference to the NS. Now that should not be needed, but that code is
> common to bdev ioctl, so keep as is.

The bdev ioctl uses nvme_ns_open() and nvme_ns_release(). So, IMO, you may also
remove nvme_ns_chr_open() and nvme_ns_chr_release() methods.

Otherwise this looks good.

Reviewed-by: Nilay Shroff <[email protected]>