Re: [PATCH 4/4] nvme: clamp FDP placement handle count to the buffer size

Christoph Hellwig <[email protected]> Thu, 30 Jul 2026 13:37:22 +0200
Newsgroups org.infradead.lists.linux-nvme
Message-ID <[email protected]>
On Thu, Jul 30, 2026 at 03:10:59PM +0530, Kanchan Joshi wrote:
> But I feel the need to improve (what we have) with a follow-up patch:
> 1. Revise the cap, from S8_MAX - 1 to U8_MAX; since bio->bi_write_hint 
> is u8.

Signed 8-bit -1 is indeed a really odd value, and from looking at the
original commit I'm not really sure how we arrived there.

> 2. And a dev_warn() to know if head->nr_plids go above the 
> kernel-defined cap. It's possible/fine for device to have more placement 
> ids, and if that happens, this can tell.

Yeah.