Re: [PATCH] block: stop the timeout timer when releasing a never added disk
Chris S <[email protected]> Thu, 30 Jul 2026 15:48:50 -0400
| Newsgroups | org.infradead.lists.linux-nvme,org.kernel.vger.linux-block,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <CACd_6n372enkmZuXJnxXaDe-PA8o-t3Nmj86s_zCgGkdYTcanw@mail.gmail.com> |
Sorry for the mistake, I think I replied to the wrong emails. Best, Chao On Wed, Jul 29, 2026 at 7:23=E2=80=AFAM Jens Axboe <[email protected]> wrote: > > > On Mon, 27 Jul 2026 16:12:57 -0400, Chao Shi wrote: > > disk_release() undoes blk_mq_init_allocated_queue() for a disk whose > > probe failed before add_disk(), but it only calls blk_mq_exit_queue(). > > Nothing there stops q->timeout, and that timer rolls forward: it stays > > pending until it next expires, not until the last request completes. > > So if the driver issued any I/O before adding the disk, the > > request_queue is freed while still linked into a timer wheel bucket. > > > > [...] > > Applied, thanks! > > [1/1] block: stop the timeout timer when releasing a never added disk > commit: 26cb8ebbfaf713c82e142d08828d4d765057633b > > Best regards, > -- > Jens Axboe > > >