Re: [PATCH v7 1/9] block: expose blk_stat_{enable,disable}_accounting() to drivers

John Garry <[email protected]>
Newsgroups org.infradead.lists.linux-nvme
Organization Oracle Corporation
Message-ID <[email protected]>
> The functions blk_stat_enable_accounting() and
> blk_stat_disable_accounting() are currently exported, but their
> prototypes are only defined in a private header. Move these prototypes
> into a common header so that block drivers can directly use these APIs.

It might be worth mentioning somewhere why this is in blk-mq.h (which I 
believe is because that these accounting functions are only relevant to 
blk-mq queues now, which would not be guessed by the function names). 
But I don't feel too strongly about this.

> 
> Reviewed-by: Hannes Reinecke <[email protected]>
> Reviewed-by: Sagi Grimberg <[email protected]>
> Signed-off-by: Nilay Shroff <[email protected]>

Reviewed-by: John Garry <[email protected]>
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.