Re: [PATCH blktests 2/2] nvme/070: Test multipath and marginal ports

On 8/14/26 07:47, Shin'ichiro Kawasaki wrote:
> On Aug 12, 2026 / 13:45, Jesse Taube wrote:
>> Add tests/nvme/070 to test various multipath and marginal port
>> scenarios, while confirming the port useage and state. This test is
>> intended to emulate receiving an FPIN event in a multipath environment.
> 
> The test contents are comprehensive, which looks good to me. 
>>
>> Suggested-by: John Meneghini <[email protected]>

Please remove the above line.

>> Signed-off-by: Jesse Taube <[email protected]>

Co-authored-by: John Menehgini <[email protected]>
Signed-off-by: John Meneghini <[email protected]>

I've tested these patches and they work.

Tested-by: John Meneghini <[email protected]>

Note: These patches require the kernel changes introduced by the "FPIN Link integrity handling" patches[1],
and they should not be merged until the kernel patches are merged.

[1] https://lore.kernel.org/linux-scsi/[email protected]/T/#m1e8c728cf2dcdfd70d1b50a2fc2f278ea0832c36


>> diff --git a/tests/nvme/070 b/tests/nvme/070
>> new file mode 100755
>> index 0000000..a8002f8
>> --- /dev/null
>> +++ b/tests/nvme/070
>> @@ -0,0 +1,521 @@
>> +#!/bin/bash
>> +# SPDX-License-Identifier: GPL-3.0+
>> +# Copyright (C) 2024 John Meneghini <[email protected]>
> 
> This patch's author is Jesse, which looks inconstent with the copyright above.
> Also, please reconfirm the copyright year 2024. Should it be "2026" or

Yes, this is because the original version of this script was authored by me.

Jesse took my first version and greatly improved it.  She got it working.
> 
> When I ran this test case on the kernel without the patch series
> "nvme-fc: FPIN link integrity handling", this test case just failed.
> I think it should be skipped if the kernel does not have set_marginal_rport
> sysfs attribute. I suggest to add the check below:

Good suggestion.

>         if [[ ! -w /sys/class/fcloop/ctl/set_marginal_rport ]]; then
>                 SKIP_REASONS+=("fcloop does not support set_marginal_rport")
>                 return 1
>         fi
> 

/John