Re: [PATCH v2] nvme: skip the zoned limits update if the zone info query failed
Christoph Hellwig <[email protected]>
| Newsgroups | org.infradead.lists.linux-nvme,org.kernel.vger.linux-kernel,org.kernel.vger.stable |
|---|---|
| Message-ID | <[email protected]> |
On Mon, Aug 17, 2026 at 03:17:22PM +0900, Damien Le Moal wrote: > On 8/17/26 04:17, Chao Shi wrote: > > nvme_query_zone_info() returns either a negative errno or a positive > > NVMe status code, but nvme_update_ns_info_block() only tests for the > > That seems like a bad design of nvme_query_zone_info(). Why not fix it so that > on error it returns either negative values OR NVMe status code? That would > avoid the pitfall of the error check that you found. Because in some case the difference matters, and this thus is a common pattern in the nvme driver.