Re: [PATCH v2] nvme: skip the zoned limits update if the zone info query failed
Chris S <[email protected]>
| Newsgroups | org.infradead.lists.linux-nvme,org.kernel.vger.linux-kernel,org.kernel.vger.stable |
|---|---|
| Message-ID | <CACd_6n3jTkxohh6joJ=HxsVtMwU3X8o863jn47gYyuh2Q-vOUw@mail.gmail.com> |
Hi Damien, Thanks for taking a look. Christoph already answered this, and I agree with him: the split return is deliberate and a common pattern in the nvme driver, because some callers do need to tell a controller-reported status apart from a local errno. This function is one of them: it opens with "ret = nvme_identify_ns(...); if (ret) return ret;", and nvme_validate_ns() then only removes the namespace on "ret > 0 && (ret & NVME_STATUS_DNR)", which it could not do if the status had been folded into an errno. So I kept the fix at the call site rather than changing the calling convention. Thanks, Chao