Re: [PATCH] nvme-rdma: fix -EIO cleanup order in queue_rq
Christoph Hellwig <[email protected]>
| Newsgroups | org.infradead.lists.linux-nvme,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
On Thu, Aug 13, 2026 at 05:45:00PM +0800, Xixin Liu wrote:
> - nvme_cleanup_cmd(rq);
> + if (err != -EIO) {
> + nvme_cleanup_cmd(rq);
> + ret = (err == -ENOMEM || err == -EAGAIN) ?
> + BLK_STS_RESOURCE : BLK_STS_IOERR;
Please stick to the much more readable if/else here.