Re: [PATCH] nvme-fc: fix double free of fabrics options when nvme_add_ctrl() fails
Keith Busch <[email protected]>
| Newsgroups | org.infradead.lists.linux-nvme,org.kernel.vger.stable |
|---|---|
| Message-ID | <aoXLiFruG5s1nKch@kbusch-mbp> |
On Mon, Aug 17, 2026 at 05:10:23PM +0200, Niklas Cassel wrote: > It seems like Keith did prefer your patch, but as you said, your patch does > not avoid a NULL pointer dereference in nvme_auth_free(). But you're replacing a NULL pointer dereference to a derefence to freed memory. That should be fixed too, and I'm just saying checking a pointer for NULL before dereferencing it is more clear than checking if a list is empty.