Re: [PATCH RFC 4/5] block: move bio validation into __bio_split_to_limits

Sagi Grimberg <[email protected]>
Newsgroups org.infradead.lists.linux-nvme,org.kernel.vger.linux-block
Message-ID <[email protected]>

On 20/05/2026 18:19, Keith Busch wrote:
> On Wed, May 20, 2026 at 09:25:48AM +0200, Christoph Hellwig wrote:
>> Moving the checking from submit_bio_noacct into __bio_split_to_limits
>> means that we lose it for bio-based drivers except for the few that
>> manuall call bio_split_to_limits.  So we'll still need a helper for
>> them, which could be called just before calling into ->submit_bio.
> Oh good point. It looks like many of them don't even want their bio's to
> split, so probably would need to factor out a limits check from the
> split so that both can call from an entered queue context. Thanks for
> the feedback.

Commented in the previous patch, would it make sense to move these
to __bio_queue_enter itself as bio_post_enter_checks() ?
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.