Re: [PATCH v1 1/1] nvme-tcp: fix wrong status on deferred digest error
Hannes Reinecke <[email protected]>
| Newsgroups | org.infradead.lists.linux-nvme,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
On 8/26/26 3:30 AM, Xixin Liu wrote: > A C2HData digest error stores a host status code in req status. Without > DATA_SUCCESS the request is completed later from the rsp path, which > passed that value straight into complete and could report the wrong > status code. > > Keep req status as a host status code. On the rsp path, shift left when > a host error was already stored, otherwise use the completion status > field. > I really don't see it. Where is the issue? AFAICS we're just changing the type of 'status' from holding the wire-value to the host value. Can you make the patch simpler by just keeping 'status' as __le16? Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect [email protected] +49 911 74053 688 SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich