Re: [PATCH] phy: renesas: rcar-gen2: Fix double of_node_put on phy creation failure
[email protected] Mon, 03 Aug 2026 12:54:48 +0000
| Newsgroups | org.infradead.lists.linux-phy |
|---|---|
| Message-ID | <[email protected]> |
VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MyBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6CgpQcmUtZXhpc3RpbmcgaXNzdWVzOgot IFtIaWdoXSBUaGUgZHJpdmVyIHNhdmVzIGEgZGV2aWNlIG5vZGUgcG9pbnRlciAoYG5wYCkgaW4g YGNoYW5uZWwtPm9mX25vZGVgIHdpdGhvdXQgYWNxdWlyaW5nIGEgcmVmZXJlbmNlLCBsZWFkaW5n IHRvIGEgcG90ZW50aWFsIGRhbmdsaW5nIHBvaW50ZXIuCi0gW0hpZ2hdIFBvdGVudGlhbCBvdXQt b2YtYm91bmRzIGFycmF5IGFjY2VzcyB3aGVuIHBvcHVsYXRpbmcgdGhlIGBkcnYtPmNoYW5uZWxz YCBhcnJheSBkdWUgdG8gYSB0aW1lLW9mLWNoZWNrIHRvIHRpbWUtb2YtdXNlIChUT0NUT1UpIHJh Y2UgY29uZGl0aW9uLgotIFtIaWdoXSBUaGUgcHJvYmUgZnVuY3Rpb24gaW5jb3JyZWN0bHkgcmV0 dXJucyBzdWNjZXNzICgwKSB3aGVuIGEgY2hpbGQgbm9kZSBoYXMgYW4gb3V0LW9mLWJvdW5kcyAn cmVnJyBwcm9wZXJ0eS4KLS0KCi0tLSBQYXRjaCBbMV06IFtQQVRDSF0gcGh5OiByZW5lc2FzOiBy Y2FyLWdlbjI6IEZpeCBkb3VibGUgb2Zfbm9kZV9wdXQgb24gcGh5IGNyZWF0aW9uIGZhaWx1cmUg LS0tCmNvbW1pdCAwMDdjZTMxMWU4NzYwZjIyNTAyYmJjMmIyNzBjMDJkZjFkOGI5ZWUwCkF1dGhv cjogRmVsaXggR3UgPHVzdGMuZ3VAZ21haWwuY29tPgoKcGh5OiByZW5lc2FzOiByY2FyLWdlbjI6 IEZpeCBkb3VibGUgb2Zfbm9kZV9wdXQgb24gcGh5IGNyZWF0aW9uIGZhaWx1cmUKClRoaXMgY29t bWl0IHJlbW92ZXMgYSByZWR1bmRhbnQgb2Zfbm9kZV9wdXQoKSBpbiB0aGUgZXJyb3IgcGF0aCBv ZgpkZXZtX3BoeV9jcmVhdGUoKS4gVGhlIGxvb3AgdXNlcyBmb3JfZWFjaF9jaGlsZF9vZl9ub2Rl X3Njb3BlZCgpLCB3aGljaAphdXRvbWF0aWNhbGx5IGhhbmRsZXMgcmVsZWFzaW5nIHRoZSBkZXZp Y2Ugbm9kZSByZWZlcmVuY2Ugb24gc2NvcGUgZXhpdC4KCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMv cGh5L3JlbmVzYXMvcGh5LXJjYXItZ2VuMi5jIGIvZHJpdmVycy9waHkvcmVuZXNhcy9waHktcmNh ci1nZW4yLmMKPiBpbmRleCA2YzY3MTI1NGM2MjU4Li41YTI3MmUyNWUwNTFjIDEwMDY0NAo+IC0t LSBhL2RyaXZlcnMvcGh5L3JlbmVzYXMvcGh5LXJjYXItZ2VuMi5jCj4gKysrIGIvZHJpdmVycy9w aHkvcmVuZXNhcy9waHktcmNhci1nZW4yLmMKPiBAQCAtNDA1LDcgKzQwNSw2IEBAIHN0YXRpYyBp bnQgcmNhcl9nZW4yX3BoeV9wcm9iZShzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2KQoKW1Nl dmVyaXR5OiBIaWdoXQpUaGlzIGlzIGEgcHJlLWV4aXN0aW5nIGlzc3VlLCBidXQgZG9lcyB0aGlz IGxvb3AgaW4gcmNhcl9nZW4yX3BoeV9wcm9iZSgpCmhhdmUgYSBwb3RlbnRpYWwgb3V0LW9mLWJv dW5kcyBhcnJheSBhY2Nlc3M/CgpUaGUgZHJpdmVyIGFsbG9jYXRlcyB0aGUgY2hhbm5lbHMgYXJy YXkgYmFzZWQgb24gb2ZfZ2V0X2NoaWxkX2NvdW50KCk6CgogICAgZHJ2LT5udW1fY2hhbm5lbHMg PSBvZl9nZXRfY2hpbGRfY291bnQoZGV2LT5vZl9ub2RlKTsKICAgIGRydi0+Y2hhbm5lbHMgPSBk ZXZtX2tjYWxsb2MoZGV2LCBkcnYtPm51bV9jaGFubmVscywgLi4uKTsKClRoZW4gaXQgaXRlcmF0 ZXMgb3ZlciB0aGUgY2hpbGQgbm9kZXM6CgogICAgZm9yX2VhY2hfY2hpbGRfb2Zfbm9kZV9zY29w ZWQoZGV2LT5vZl9ub2RlLCBucCkgewogICAgICAgIHN0cnVjdCByY2FyX2dlbjJfY2hhbm5lbCAq Y2hhbm5lbCA9IGRydi0+Y2hhbm5lbHMgKyBpOwogICAgICAgIC4uLgogICAgICAgIGkrKzsKICAg IH0KCklmIGEgY2hpbGQgbm9kZSBpcyBhZGRlZCBjb25jdXJyZW50bHkgdG8gdGhlIGRldmljZSB0 cmVlIChlLmcuLCB2aWEgYW4Kb3ZlcmxheSkgYmV0d2VlbiB0aGUgY291bnQgYW5kIHRoZSBsb29w LCBjb3VsZCBpIGV4Y2VlZCB0aGUgYWxsb2NhdGVkIHNpemUKb2YgdGhlIGFycmF5PwoKW1NldmVy aXR5OiBIaWdoXQpUaGlzIGlzIGEgcHJlLWV4aXN0aW5nIGlzc3VlLCBidXQgZG9lcyB0aGlzIGNv ZGUgc2F2ZSBhIGRldmljZSBub2RlIHBvaW50ZXIKd2l0aG91dCB0YWtpbmcgYSByZWZlcmVuY2U/ CgpJbnNpZGUgdGhlIHNhbWUgZm9yX2VhY2hfY2hpbGRfb2Zfbm9kZV9zY29wZWQoKSBsb29wIGlu CnJjYXJfZ2VuMl9waHlfcHJvYmUoKToKCiAgICBjaGFubmVsLT5vZl9ub2RlID0gbnA7CgpUaGUg aXRlcmF0b3IgYXV0b21hdGljYWxseSBkcm9wcyB0aGUgcmVmZXJlbmNlIHRvIG5wIHdoZW4gYWR2 YW5jaW5nIHRvIHRoZQpuZXh0IGl0ZXJhdGlvbiBvciB3aGVuIHRoZSBsb29wIHRlcm1pbmF0ZXMu IElmIHRoZSBkZXZpY2UgdHJlZSBvdmVybGF5IGlzCnJlbW92ZWQgYW5kIHRoZSBub2RlIGlzIGZy ZWVkLCBjb3VsZCB0aGlzIHJlc3VsdCBpbiBhIGRhbmdsaW5nIHBvaW50ZXIgd2hlbgphY2Nlc3Nl ZCBsYXRlcj8KClNob3VsZCBpdCB1c2Ugb2Zfbm9kZV9nZXQoKSB0byBpbmNyZW1lbnQgdGhlIHJl ZmVyZW5jZSBjb3VudD8KCltTZXZlcml0eTogSGlnaF0KVGhpcyBpcyBhIHByZS1leGlzdGluZyBp c3N1ZSwgYnV0IGNhbiB0aGlzIGVycm9yIGhhbmRsaW5nIGJsb2NrIHJldHVybiAwCmluc3RlYWQg b2YgYSBwcm9wZXIgZXJyb3IgY29kZT8KCldoZW4gdmFsaWRhdGluZyB0aGUgInJlZyIgcHJvcGVy dHkgaW4gcmNhcl9nZW4yX3BoeV9wcm9iZSgpOgoKICAgIGVycm9yID0gb2ZfcHJvcGVydHlfcmVh ZF91MzIobnAsICJyZWciLCAmY2hhbm5lbF9udW0pOwogICAgaWYgKGVycm9yIHx8IGNoYW5uZWxf bnVtID49IGRhdGEtPm51bV9jaGFubmVscykgewogICAgICAgIGRldl9lcnIoZGV2LCAiSW52YWxp ZCBcInJlZ1wiIHByb3BlcnR5XG4iKTsKICAgICAgICByZXR1cm4gZXJyb3I7CiAgICB9CgpJZiBv Zl9wcm9wZXJ0eV9yZWFkX3UzMigpIHN1Y2NlZWRzLCBlcnJvciBpcyBzZXQgdG8gMC4gSWYgdGhl IGNoYW5uZWxfbnVtIGlzCnN1YnNlcXVlbnRseSBmb3VuZCB0byBiZSBvdXQgb2YgYm91bmRzLCB0 aGUgY29uZGl0aW9uIGV2YWx1YXRlcyB0byB0cnVlLgoKV291bGQgcmV0dXJuaW5nIGVycm9yIGhl cmUgZmFsc2VseSBzaWduYWwgdG8gdGhlIGRyaXZlciBjb3JlIHRoYXQgdGhlIHByb2JlCnN1Y2Nl ZWRlZD8KCj4gIAkJCQkJCSAgIGRhdGEtPmdlbjJfcGh5X29wcyk7Cj4gIAkJCWlmIChJU19FUlIo cGh5LT5waHkpKSB7Cj4gIAkJCQlkZXZfZXJyKGRldiwgIkZhaWxlZCB0byBjcmVhdGUgUEhZXG4i KTsKPiAtCQkJCW9mX25vZGVfcHV0KG5wKTsKPiAgCQkJCXJldHVybiBQVFJfRVJSKHBoeS0+cGh5 KTsKPiAgCQkJfQo+ICAJCQlwaHlfc2V0X2RydmRhdGEocGh5LT5waHksIHBoeSk7CgotLSAKU2Fz aGlrbyBBSSByZXZpZXcgwrcgaHR0cHM6Ly9zYXNoaWtvLmRldi8jL3BhdGNoc2V0LzIwMjYwODAz LXJjYXItZ2VuMi12MS0xLTlhYTM1YzM2ZDdkN0BnbWFpbC5jb20/cGFydD0xCgotLSAKbGludXgt cGh5IG1haWxpbmcgbGlzdApsaW51eC1waHlAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwczovL2xp c3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1waHkK