Re: [PATCH] phy: renesas: rcar-gen2: Return -EINVAL for out-of-range channel reg

[email protected] Mon, 03 Aug 2026 13:18:15 +0000
Newsgroups org.infradead.lists.linux-phy
Message-ID <[email protected]>
VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg
NCBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6CgpQcmUtZXhpc3RpbmcgaXNzdWVzOgot
IFtIaWdoXSBDYWxsaW5nIGV4cGxpY2l0IGBvZl9ub2RlX3B1dChucClgIGluc2lkZSBhIGBmb3Jf
ZWFjaF9jaGlsZF9vZl9ub2RlX3Njb3BlZCgpYCBsb29wIGNhdXNlcyBhIGRvdWJsZS1mcmVlIG9u
IHRoZSBlcnJvciBwYXRoLgotIFtIaWdoXSBTdG9yaW5nIGEgZGV2aWNlIG5vZGUgcG9pbnRlciBp
biBgY2hhbm5lbC0+b2Zfbm9kZWAgd2l0aG91dCBpbmNyZW1lbnRpbmcgaXRzIHJlZmVyZW5jZSBj
b3VudCBsZWFkcyB0byBhIGRhbmdsaW5nIHBvaW50ZXIuCi0gW0hpZ2hdIGByY2FyX2dlbjJfcGh5
X2luaXQoKWAgaWdub3JlcyB0aGUgcmV0dXJuIHZhbHVlIG9mIGBjbGtfcHJlcGFyZV9lbmFibGUo
KWAsIHBvdGVudGlhbGx5IGFjY2Vzc2luZyB1bmNsb2NrZWQgaGFyZHdhcmUuCi0gW0hpZ2hdIER5
bmFtaWMgZGV2aWNlIHRyZWUgbm9kZSBhZGRpdGlvbiBiZXR3ZWVuIG5vZGUgY291bnQgYW5kIGl0
ZXJhdGlvbiBjYXVzZXMgb3V0LW9mLWJvdW5kcyBhcnJheSBhY2Nlc3MuCi0tCgotLS0gUGF0Y2gg
WzFdOiBbUEFUQ0hdIHBoeTogcmVuZXNhczogcmNhci1nZW4yOiBSZXR1cm4gLUVJTlZBTCBmb3Ig
b3V0LW9mLXJhbmdlIGNoYW5uZWwgcmVnIC0tLQpjb21taXQgMTE4MmUyYjVmNjQzN2UwODIzMzIx
M2YzMzRkYWQ0MWU2YWYxMzdmYQpBdXRob3I6IEZlbGl4IEd1IDx1c3RjLmd1QGdtYWlsLmNvbT4K
CnBoeTogcmVuZXNhczogcmNhci1nZW4yOiBSZXR1cm4gLUVJTlZBTCBmb3Igb3V0LW9mLXJhbmdl
IGNoYW5uZWwgcmVnCgpXaGVuIG9mX3Byb3BlcnR5X3JlYWRfdTMyKCkgc3VjY2VlZHMgYnV0IGNo
YW5uZWxfbnVtIGV4Y2VlZHMKZGF0YS0+bnVtX2NoYW5uZWxzLCB0aGUgcHJvYmUgZnVuY3Rpb24g
ZXJyb25lb3VzbHkgcmVwb3J0cyBzdWNjZXNzIGRlc3BpdGUgCm5vIFBIWSBwcm92aWRlciBiZWlu
ZyByZWdpc3RlcmVkLiBUaGlzIGNvbW1pdCBmaXhlcyB0aGUgaXNzdWUgYnkgcmV0dXJuaW5nIAot
RUlOVkFMIGluIHRoYXQgc3BlY2lmaWMgY2FzZS4KCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvcGh5
L3JlbmVzYXMvcGh5LXJjYXItZ2VuMi5jIGIvZHJpdmVycy9waHkvcmVuZXNhcy9waHktcmNhci1n
ZW4yLmMKPiBpbmRleCA2YzY3MTI1NGM2MjU4Li5mMDg1OGQ4Y2M3MDU2IDEwMDY0NAo+IC0tLSBh
L2RyaXZlcnMvcGh5L3JlbmVzYXMvcGh5LXJjYXItZ2VuMi5jCj4gKysrIGIvZHJpdmVycy9waHkv
cmVuZXNhcy9waHktcmNhci1nZW4yLmMKPiBAQCAtMzkwLDcgKzM5MCw3IEBAIHN0YXRpYyBpbnQg
cmNhcl9nZW4yX3BoeV9wcm9iZShzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2KQo+ICAJCWVy
cm9yID0gb2ZfcHJvcGVydHlfcmVhZF91MzIobnAsICJyZWciLCAmY2hhbm5lbF9udW0pOwo+ICAJ
CWlmIChlcnJvciB8fCBjaGFubmVsX251bSA+PSBkYXRhLT5udW1fY2hhbm5lbHMpIHsKPiAgCQkJ
ZGV2X2VycihkZXYsICJJbnZhbGlkIFwicmVnXCIgcHJvcGVydHlcbiIpOwo+IC0JCQlyZXR1cm4g
ZXJyb3I7Cj4gKwkJCXJldHVybiBlcnJvciA/OiAtRUlOVkFMOwo+ICAJCX0KPiAgCQljaGFubmVs
LT5zZWxlY3RfbWFzayA9IHNlbGVjdF9tYXNrW2NoYW5uZWxfbnVtXTsKPiAgCgpbU2V2ZXJpdHk6
IEhpZ2hdClRoaXMgaXMgYSBwcmUtZXhpc3RpbmcgaXNzdWUsIGJ1dCBjb3VsZCB0aGUgZXhwbGlj
aXQgb2Zfbm9kZV9wdXQobnApIGluc2lkZQpmb3JfZWFjaF9jaGlsZF9vZl9ub2RlX3Njb3BlZCgp
IGNhdXNlIGEgZG91YmxlLWZyZWU/CgpUaGUgc2NvcGVkIGl0ZXJhdG9yIGFscmVhZHkgYXV0b21h
dGljYWxseSBjbGVhbnMgdXAgdGhlIG5vZGUgcmVmZXJlbmNlIG9uCmVhcmx5IHJldHVybnMuIElz
IGl0IHBvc3NpYmxlIHRoYXQgdGhpcyBleHBsaWNpdCBwdXQgY29ycnVwdHMgdGhlIHJlZmVyZW5j
ZQpjb3VudDoKCmRyaXZlcnMvcGh5L3JlbmVzYXMvcGh5LXJjYXItZ2VuMi5jOnJjYXJfZ2VuMl9w
aHlfcHJvYmUoKSB7CiAgICAuLi4KCQlmb3IgKG4gPSAwOyBuIDwgUEhZU19QRVJfQ0hBTk5FTDsg
bisrKSB7CiAgICAuLi4KCQkJcGh5LT5waHkgPSBkZXZtX3BoeV9jcmVhdGUoZGV2LCBOVUxMLAoJ
CQkJCQkgICBkYXRhLT5nZW4yX3BoeV9vcHMpOwoJCQlpZiAoSVNfRVJSKHBoeS0+cGh5KSkgewoJ
CQkJZGV2X2VycihkZXYsICJGYWlsZWQgdG8gY3JlYXRlIFBIWVxuIik7CgkJCQlvZl9ub2RlX3B1
dChucCk7CgkJCQlyZXR1cm4gUFRSX0VSUihwaHktPnBoeSk7CgkJCX0KICAgIC4uLgp9CgoKW1Nl
dmVyaXR5OiBIaWdoXQpUaGlzIGlzIGEgcHJlLWV4aXN0aW5nIGlzc3VlLCBidXQgSSBhbSB3b25k
ZXJpbmcgaWYgdGhpcyBsZWF2ZXMgYSBkYW5nbGluZwpwb2ludGVyIGluIGNoYW5uZWwtPm9mX25v
ZGU/CgpUaGUgc2NvcGVkIGl0ZXJhdG9yIGF1dG9tYXRpY2FsbHkgZHJvcHMgdGhlIHJlZmVyZW5j
ZSB0byBucCB3aGVuIGl0CmFkdmFuY2VzIG9yIHRlcm1pbmF0ZXMsIGJ1dCB0aGUgcG9pbnRlciBp
cyBzYXZlZCB3aXRob3V0IGFjcXVpcmluZyBhCnJlZmVyZW5jZSB2aWEgb2Zfbm9kZV9nZXQoKToK
CmRyaXZlcnMvcGh5L3JlbmVzYXMvcGh5LXJjYXItZ2VuMi5jOnJjYXJfZ2VuMl9waHlfcHJvYmUo
KSB7CiAgICAuLi4KCWZvcl9lYWNoX2NoaWxkX29mX25vZGVfc2NvcGVkKGRldi0+b2Zfbm9kZSwg
bnApIHsKCQlzdHJ1Y3QgcmNhcl9nZW4yX2NoYW5uZWwgKmNoYW5uZWwgPSBkcnYtPmNoYW5uZWxz
ICsgaTsKCQkuLi4KCQljaGFubmVsLT5vZl9ub2RlID0gbnA7CiAgICAuLi4KfQoKQ2FuIHRoaXMg
dW5yZWZlcmVuY2VkIHBvaW50ZXIgbGF0ZXIgYmUgdXNlZCBmb3IgY29tcGFyaXNvbiBhbmQgY2F1
c2UKaW5jb3JyZWN0IFBIWSBpbnN0YW5jZXMgdG8gYmUgcmV0dXJuZWQgaWYgdGhlIGRldmljZSB0
cmVlIG5vZGUgaXMKZHluYW1pY2FsbHkgZnJlZWQ/Cgpkcml2ZXJzL3BoeS9yZW5lc2FzL3BoeS1y
Y2FyLWdlbjIuYzpyY2FyX2dlbjJfcGh5X3hsYXRlKCkgewogICAgLi4uCglmb3IgKGkgPSAwOyBp
IDwgZHJ2LT5udW1fY2hhbm5lbHM7IGkrKykgewoJCWlmIChucCA9PSBkcnYtPmNoYW5uZWxzW2ld
Lm9mX25vZGUpCgkJCWJyZWFrOwoJfQogICAgLi4uCn0KCgpbU2V2ZXJpdHk6IEhpZ2hdClRoaXMg
aXNuJ3QgYSBidWcgaW50cm9kdWNlZCBieSB0aGlzIHBhdGNoLCBidXQgaXQgbG9va3MgbGlrZQpy
Y2FyX2dlbjJfcGh5X2luaXQoKSBpZ25vcmVzIHRoZSByZXR1cm4gdmFsdWUgb2YgY2xrX3ByZXBh
cmVfZW5hYmxlKCkuCgpJZiB0aGUgY2xvY2sgZmFpbHMgdG8gZW5hYmxlLCB0aGUgZHJpdmVyIHBy
b2NlZWRzIHRvIGFjcXVpcmUgYSBzcGlubG9jawphbmQgd3JpdGUgdG8gdGhlIFVTQkhTX1VHQ1RS
TDIgaGFyZHdhcmUgcmVnaXN0ZXI6Cgpkcml2ZXJzL3BoeS9yZW5lc2FzL3BoeS1yY2FyLWdlbjIu
YzpyY2FyX2dlbjJfcGh5X2luaXQoKSB7CiAgICAuLi4KCWNsa19wcmVwYXJlX2VuYWJsZShkcnYt
PmNsayk7CgoJc3Bpbl9sb2NrX2lycXNhdmUoJmRydi0+bG9jaywgZmxhZ3MpOwoJdWdjdHJsMiA9
IHJlYWRsKGRydi0+YmFzZSArIFVTQkhTX1VHQ1RSTDIpOwogICAgLi4uCn0KCldvdWxkIHRoaXMg
YWNjZXNzIHVuY2xvY2tlZCBoYXJkd2FyZSBhbmQgcmVzdWx0IGluIGEgZmF0YWwgYnVzIGVycm9y
PwoKCltTZXZlcml0eTogSGlnaF0KVGhpcyBpc24ndCBhIGJ1ZyBpbnRyb2R1Y2VkIGJ5IHRoaXMg
cGF0Y2gsIGJ1dCBtaWdodCB0aGVyZSBiZSBhbgpvdXQtb2YtYm91bmRzIGFycmF5IGFjY2VzcyBo
ZXJlIGlmIGNoaWxkIG5vZGVzIGFyZSBkeW5hbWljYWxseSBhZGRlZD8KClRoZSBwcm9iZSBmdW5j
dGlvbiBhbGxvY2F0ZXMgdGhlIGRydi0+Y2hhbm5lbHMgYXJyYXkgZXhhY3RseSB0byB0aGUKY3Vy
cmVudCBjaGlsZCBjb3VudCwgYnV0IGl0ZXJhdGVzIG92ZXIgcG90ZW50aWFsbHkgbW9kaWZpZWQg
Y2hpbGRyZW4gdXNpbmcKYW4gdW5ib3VuZGVkIGluZGV4IGkgdG8gd3JpdGUgdG8gZHJ2LT5jaGFu
bmVscyArIGk6Cgpkcml2ZXJzL3BoeS9yZW5lc2FzL3BoeS1yY2FyLWdlbjIuYzpyY2FyX2dlbjJf
cGh5X3Byb2JlKCkgewogICAgLi4uCglkcnYtPm51bV9jaGFubmVscyA9IG9mX2dldF9jaGlsZF9j
b3VudChkZXYtPm9mX25vZGUpOwoJZHJ2LT5jaGFubmVscyA9IGRldm1fa2NhbGxvYyhkZXYsIGRy
di0+bnVtX2NoYW5uZWxzLAoJCQkJICAgICBzaXplb2Yoc3RydWN0IHJjYXJfZ2VuMl9jaGFubmVs
KSwKCQkJCSAgICAgR0ZQX0tFUk5FTCk7CiAgICAuLi4KCWZvcl9lYWNoX2NoaWxkX29mX25vZGVf
c2NvcGVkKGRldi0+b2Zfbm9kZSwgbnApIHsKCQlzdHJ1Y3QgcmNhcl9nZW4yX2NoYW5uZWwgKmNo
YW5uZWwgPSBkcnYtPmNoYW5uZWxzICsgaTsKICAgICAgICAuLi4KCQlpKys7Cgl9CiAgICAuLi4K
fQoKQ291bGQgYSBkZXZpY2UgdHJlZSBvdmVybGF5IGFkZGVkIGJldHdlZW4gdGhlIGNvdW50IGFu
ZCB0aGUgbG9vcCBjYXVzZSBhCmhlYXAgYnVmZmVyIG92ZXJmbG93PwoKLS0gClNhc2hpa28gQUkg
cmV2aWV3IMK3IGh0dHBzOi8vc2FzaGlrby5kZXYvIy9wYXRjaHNldC8yMDI2MDgwMy1yY2FyLWdl
bjItMS12MS0xLTQ3OTZlYTZlNzZkOEBnbWFpbC5jb20/cGFydD0xCgotLSAKbGludXgtcGh5IG1h
aWxpbmcgbGlzdApsaW51eC1waHlAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwczovL2xpc3RzLmlu
ZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1waHkK