Re: [PATCH] phy: sunplus: fix error handling in sp_uphy_init()
Philipp Zabel <[email protected]> Mon, 03 Aug 2026 17:22:40 +0200
| Newsgroups | org.infradead.lists.linux-phy,org.kernel.vger.linux-kernel,org.kernel.vger.linux-usb |
|---|---|
| Message-ID | <[email protected]> |
On Mo, 2026-08-03 at 23:15 +0800, Felix Gu wrote:
> Fix the error paths of sp_uphy_init() to undo exactly what each stage
> did: return directly if clk_prepare_enable() fails, release only the clock
> if reset_control_deassert() fails, and jump to err_reset if
> update_disc_vol() fails so the clock and reset are not leaked.
>
> Fixes: 99d9ccd97385 ("phy: usb: Add USB2.0 phy driver for Sunplus SP7021")
> Signed-off-by: Felix Gu <[email protected]>
Reviewed-by: Philipp Zabel <[email protected]>
regards
Philipp
--
linux-phy mailing list
[email protected]
https://lists.infradead.org/mailman/listinfo/linux-phy